Brave-browser: [Desktop] Saved passwords are not shown in brave://settings/passwords

[kenthunt]

New issue description (edit by bsclifton)

Passwords are definitely being saved by the browser, however they are not showing up under brave://settings/passwords

Original issue description

I installed the new Brave Browser version, and after that no longer can view saved passwords. Import does not work from Brave Browser. I can verify that the passwords are in "Login Data" and that if I visit a website, it will populate the username and password.

Steps to Reproduce (edit by simonhong)

Scenario 1: (Not a valid STR because we don't support muon anymore - simonhong)

1. Install New Brave Browser
2. Observe your old Brave Browser does not show you passwords anymore
3. Import passwords from Brave (old) does not work in new Brave Browser

Scenario 2:

1. Save some passwords by using Chrome and copy chrome's Login Data in user's profile folder to Brave's folder
2. Launch Brave and checks Saved Passwords section(brave://settings/passwords) is empty
3. Update and save some passwords by revisiting some websites
4. Check Saved Passwords section displays newly added passwords

Actual result:

I have lost the ability to export individual passwords as needed from Brave. The passwords are still there.

Expected result:

Brave provides interactive access to saved passwords. New Brave Browser imports the old passwords successfully.

Reproduces how often:

Tried this once. Now am stuck with a website that is timing out and cannot export password to try a different computer / brave install.

Brave version (brave://version info)

Brave: 0.25.302
V8: 6.9.427.23
rev: 91cc80471c0afe6a2306357177ab8680a439be69
Muon: 8.1.8
OS Release: 17.7.0
Update Channel: Release
OS Architecture: x64
OS Platform: macOS
Node.js: 7.9.0
Brave Sync: v1.4.2
libchromiumcontent: 69.0.3497.100

Reproducible on current release:

• Does it reproduce on brave-browser dev/beta builds?
  Have not tried this.

Website problems only:

• Does the issue resolve itself when disabling Brave Shields?
• Is the issue reproducible on the latest version of Chrome?
  No this is a Brave defect.

Additional Information

I may have said no when asked during New Brave Browser to import all old settings. I'm not sure...

[kenthunt]

Same behavior with the current Beta Brave version. Does not import existing Brave (old) passwords.

[srirambv]

Are you still able to use the saved passwords on muon browser even though its not visible in the about:passwords page? If its working then can you try closing muon and then trying to import passwords into brave-core?

[sharifzadesina]

Same here.
It is always like this:
"Saved password will appear here"
But nothing appears.

[bcehprx]

I just tried installing Brave Version 0.65.120 Chromium: 75.0.3770.90 (Official Build) (64-bit) on Ubuntu 18.04.1 LTS. I used the save password popup and I can see the website and password entry in the setting "Saved Passwords", and clicking on the show password eye icon reveals it. In passing, I was not asked for a machine login password, as I am with Windows.

[bcehprx]

I also closed the browser and re-opened it, and the entry was still in "Saved Passwords".

[erezrokah]

I'm having the same issue of Brave stopping to show/save my passwords:

Also, Brave offers to save passwords, but when I click save the password is not added to the list:

The only solution I found is to create a new profile (Manage people->Add person) but then I lose all my existing passwords

I'm using Brave | 0.66.99 Chromium: 75.0.3770.100 (Official Build) (64-bit) on Ubuntu 18.04.2 LTS

[simurgh9]

I have the same problem in Version 0.68.138 Chromium: 77.0.3865.75 (Official Build) (64-bit). Also, it looks like it deletes some saved passwords at times like I had GitHub's password saved and it did not have it. I also had issues trying to import passwords from chrome. I tried manually copying the password files, which did not work either. Right now, it saves passwords fine and prompts to auto-fill them but does not show them indexed in the manage passwords portion of settings.

[yfrommelt]

Same in Version 1.1.20 Chromium: 79.0.3945.74 (Official Build) (64-bit)

[sd0minick]

I have the same issue.
The password is saved on a particular site but when searching for it in the preferences, it is totally empty.
So I have to reset the password so I can log into another device

[webargus]

I'm having the same problem.

[HakeemIshak]

I'm also experiencing the same problem, can use my saved password but cannot view list of "Saved Password"

[bsclifton]

I'm seeing this too- I definitely have saved passwords, but they aren't showing

This issue was originally tracking the use-case where people would import from the older "Muon" based Brave browser into this new Brave Core version. But the issue is definitely bigger than that. Going to re-characterize this issue a bit

cc: @rebron @kjozwiak @LaurenWags - curious if you all have ran into this?

[BachoSeven]

Same issue here- Brave Beta Browser latest release, passwords were imported and I saved passwords but it asks to save them again; and in settings they don't show up

EDIT: For future reference, my problem got fixed by itself some time after, I guess sometimes it just takes some time for the imported passwords to show up. Also, I switched to nightly and never had the issue again

EDIT: Aaand of course now that I edited the post they stopped showing again...

[pixmix]

I see the issue here already for several weeks. Password are actually recorded, but are not visible in the management interface.

Version 1.2.43 Chromium: 79.0.3945.130 (Official Build) (64-bit)
running on Linux [user] 4.15.0-76-generic #86~16.04.1-Ubuntu SMP Mon Jan 20 11:02:50 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

[michaeltintiuc]

Just happened to me with Version 1.3.115 Chromium: 80.0.3987.87 (Official Build) (64-bit) On Linux, it used to work with 1.2.x

[ghost]

Yup, very similar to the behavior reported before. Plus, in some cases the saved password aren't automatically filled in the login form (I can't tell why it works for some sites and not the others).
I am on
Version 1.3.115 Chromium: 80.0.3987.87 (Official Build) (64-bit)

It is unfortunate, that what seems to be major issue hasn't been addressed for over a year now.

[scorpion35]

I am on a mac and was using Brave for over an year without an issues. Suddenly last week all my passwords were gone. This is what I've done to resolve the issue -

Removed these -

1. /Applications/Brave Browser.app
2. ~/Library/Application Support/BraveSoftware/

Downloaded Brave from Chrome browser (oh Chrome, what happened to you? Used to open IE to download Chrome. And now opened Chrome just to download Brave). New installation is saving passwords correctly. Unfortunately though, I need to visit lot of pages and save passwords again, but it's at least working.

[bsclifton]

@scorpion35 interesting- seems to point at the profile being corrupt (ex: profile is what's under ~/Library/Application Support/BraveSoftware/). I believe the passwords are stored in a sqlite DB - maybe there is a file with metadata that is not up to date. The passwords are clearly there (logins work), just not showing on the page

[HakeemIshak]

I'm on Linux, I managed to see back my password by removing only the sqlite DB (Login Data). But of course I had to saved back my password to see it again

[removed] /home/{username}/.config/BraveSoftware/Brave-Browser/Default/Login Data

Probably something went wrong with the file.

Edit :
Found one trick to restore previous ones is to export/import them to new DB. But I suspect certain password field is corrupted which causing it to not appear in Password Manager. Once I manually fix the corrupted ones (set it empty), I managed to see back all the password saved.

[ghost]

Thanks @hakeem-ishak - deleting the DB worked for me as well (on Ubuntu). This is a workaround indeed. Very much like workarounds in Microsoft software - turn it off then on - it should work again ;)
I think your analysis is correct - a certain state isn't being preserved in the DB during the upgrades, which causes this effect.

[tangodev]

Hello,

I mentioned this here: https://www.reddit.com/r/brave_browser/comments/dsd3bz/password_manager_restore_and_usage_can_not/

I'm on Ubuntu and just tried the latest production version of Brave:

ii  brave-browser                                   1.4.95                                          amd64        The web browser from Brave
ii  brave-keyring                                   1.9                                             all          Brave Browser keyring and repository files

Sadly, the same result. I've never used the Muon edition of Brave, I started using the browser just a few months ago. I tested with:

Brave   1.4.95 Chromium: 80.0.3987.122 (Official Build) (64-bit)
Revision    cf72c4c4f7db75bc3da689cd76513962d31c7b52-refs/branch-heads/3987@{#943}
OS  Linux
JavaScript  V8 8.0.426.25
Flash   (Disabled)
User Agent  Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.122 Safari/537.36
Command Line    /opt/brave.com/brave/brave --enable-dom-distiller --disable-domain-reliability --no-pings --extension-content-verification=enforce_strict --extensions-install-verification=enforce --sync-url=https://no-thanks.invalid --enable-features=PasswordImport,WebUIDarkMode,SimplifyHttpsIndicator --disable-features=AutofillServerCommunication,LookalikeUrlNavigationSuggestionsUI,VideoPlaybackQuality,NotificationTriggers,WebXrGamepadModule,AllowPopupsDuringPageUnload,SmsReceiver,AudioServiceOutOfProcess,WebXR --flag-switches-begin --flag-switches-end --disable-webrtc-apm-in-audio-service --disable-sync
Executable Path /opt/brave.com/brave/brave
Profile Path    /home/vagrant/.config/BraveSoftware/Brave-Browser/Default 

1. Ran Brave and saved one password
2. Turned Brave off
3. Copied folder /home/vagrant/.config/BraveSoftware outside VM
4. Did vagrant destroy and vagrant up on VM
5. Loaded back folder BraveSoftware into /home/vagrant/.config/
6. Password missing

I think this issue needs more attention. I can't recommend Brave to my friends with a clear conscience when this bug has caused me to loose my passwords two times already. :(

[tangodev]

My two extra cents: this may be the reason why some people cannot sync their passwords: https://www.reddit.com/r/brave_browser/comments/b49tvf/moving_brave_profiles_from_one_machine_to_another/

If something is wrong with the password database or its metadata, it makes no difference if the data is copied via sync or strictly on disk.

[chrisgeorge-mya]

Same issue here. Passwords look like they still exist, but Brave is not currently loading them.

Version 1.5.112 Chromium: 80.0.3987.132 (Official Build) (64-bit)

[javierlopezdeancos]

Same issue with last Brave version on ubuntu 19

[dydokamil]

what happened? I did not enter my master password when it asked me at lanuch, and it deleted all my passwords...

Manjaro 19.0.2; Brave V1.5.123

[duaneking]

Cant view any passwords and the manager doesnt even show up

[TripleSpeeder]

I'm also having the same issue since several weeks:
brave://settings/passwords does not show the existing passwords.
However the passwords are still there, when opening a site that requires login, brave autofills the password.

Version 1.8.95 Chromium: 81.0.4044.138 (Official Build) unknown (64-bit)

Running on Arch linux.

[matthewmarcus]

How is this still an issue? It's been this way for over a year now. Can we please get it fixed.

I just updated Brave to Version 1.8.96 Chromium: 81.0.4044.138 (Official Build) (64-bit) on a Macbook Pro and the problem remains intact.

[cnm2020]

This is fucking BULLSHIT

[gfadini]

I have the same exact problem described for the manjaro package.
The passwords are saved but not visible, this seems crazy to me
Moreover apparenlty this workaround https://github.com/brave/brave-browser/issues/3196#issuecomment-591304298 is not working in my case

[fearandtrembling]

I'm having the same problem. I was logged out of everything. Twitter sent me an email saying I had a new login

[cnm2020]

This problem which everyone is having but only some have realised yet is a serious problem. It needs to be fixed asap. This is a security breach - its like if you were looking for the keys to your house and someone you dont know says oh dont worry I have them in my possession ill hold onto them you dont need them just let me know when you want it unlocked. If you own the keys you own the house. I believe this has happened because since the last update they put all our passwords onto another account on the cloud and I also believe they know about this did it on purpose and dont intend on fixing this problem, basically our security and all our accounts have been compromised, if you go ahead and change all your passwords and resave them you would only crystallise their hack, nothing is truly private on the cloud how they want it. Firefox is made by Google.

[simonhong]

It's hard for me to reproduce this issue on my local machine.
So, started to investigate this problem based on user's feedbacks.

According to the above comments, stored passwords are not visible in brave://settings/passwords.
However, passwords are filled to web page's password form.

User's password is stored to Login Data file in user profile's data and
browser get/sets password to that file via LoginDatabase class.

I found that different methods of LoginDatabase are used for above two different situations.
For settings page, password infos are fetched via LoginDatabase::GetAutofillableLogins and
LoginDatabase::GetLogins is used to fill passwords into webpage's password form.

I'm not sure but I suspect LoginDatabase::GetAutofillableLogins can't get data properly.

[cnm2020]

In the settings page, to view the passwords, you have to press the icon beside the password of an eye which temporarily reveals the password on the screen - it does nothing, pressing this icon does not toggle the password between dots and the actual password characters, and the icon beside the eye for copy does not copy the password to clipboard either

[simonhong]

@cnm2020 Do you have same issue and you can see password entries in settings but it's not revealed after clicking eye button?

[simonhong]

@cnm2020 I think this is some what different issue if you can see your saved entries because others in this issues can't see anything in Saved Passwords section like this https://github.com/brave/brave-browser/issues/3196#issuecomment-502797830

[cnm2020]

Yes, i have this issue, password entries in settings (appearing as dots) are not revealed after clicking eye

[simonhong]

@cnm2020 Your issue seems different. You can see your entries but this issue is for saved passwords section is totally empty.

[cnm2020]

No, its exactly the same. There isnt two issues here. I cannot see my passwords at all, and this has been since that same last update, its the same issue as the first user and all the others

[cnm2020]

I installed the new Brave Browser version, and after that no longer can view saved passwords. Import does not work from Brave Browser. I can verify that the passwords are in "Login Data" and that if I visit a website, it will populate the username and password.

[cnm2020]

Ok maybe its slightly different, a list does populate for me in settings but I still cant see the passwords and this is really really wromg and im frustrated and annoyed and whatever

[cnm2020]

Im sure if i posted a whole new issue ticket I would be told its already posted here or to come here and just be ignored. I feel this is a hopeless situation for me just as I expected it would be, there wont be a fix, im wasting my time, I cant simply recover these accounts, I need these saved password records but they are broken and I feel robbed.

[simonhong]

@cnm2020 Please don't feel like that. If different issues are mixed in one issue, it makes confusing. This is the only reason. and Our devs started to debug this issue.

[cnm2020]

Ok then, well thanks anyway and good luck with it

[scorpion35]

It's hard for me to reproduce this issue on my local machine.
So, started to investigate this problem based on user's feedbacks.

According to the above comments, stored passwords are not visible in brave://settings/passwords.
However, passwords are filled to web page's password form.

User's password is stored to Login Data file in user profile's data and
browser get/sets password to that file via LoginDatabase class.

I found that different methods of LoginDatabase are used for above two different situations.
For settings page, password infos are fetched via LoginDatabase::GetAutofillableLogins and
LoginDatabase::GetLogins is used to fill passwords into webpage's password form.

I'm not sure but I suspect LoginDatabase::GetAutofillableLogins can't get data properly.

I think I might have a potential repro -

• Try wrong password at system login multiple times until the OS (I am on Mac OS) forces you to reset your password
• Set your new password and login
• Open Brave and see the passwords might not be shown.

Hope that helps!

[matthewmarcus]

It's hard for me to reproduce this issue on my local machine.
So, started to investigate this problem based on user's feedbacks.
According to the above comments, stored passwords are not visible in brave://settings/passwords.
However, passwords are filled to web page's password form.
User's password is stored to Login Data file in user profile's data and
browser get/sets password to that file via LoginDatabase class.
I found that different methods of LoginDatabase are used for above two different situations.
For settings page, password infos are fetched via LoginDatabase::GetAutofillableLogins and
LoginDatabase::GetLogins is used to fill passwords into webpage's password form.
I'm not sure but I suspect LoginDatabase::GetAutofillableLogins can't get data properly.

I think I might have a potential repro -

• Try wrong password at system login multiple times until the OS (I am on Mac OS) forces you to reset your password
• Set your new password and login
• Open Brave and see the passwords might not be shown.

Hope that helps!

@scorpion35 What makes you think this solution will work. The OS layer doesn't have anything to do with Brave application.

I'm glad to see this bug getting new life and exposure. The devs really need to fix it. Surprised it hasn't been solved despite all the Brave application updates since it was first reported.

What do we need to do to raise priority? Pay $$$$? Pay Bitcoin??? Because I would.

[bsclifton]

What do we need to do to raise priority? Pay $$$$? Pay Bitcoin??? Because I would.

Having a set of steps that cause this bug to happen would greatly help us with finding and fixing the issue. @simonhong has investigated for several hours; I shared some profiles I had which were broken. I've put in some time on this too and unfortunately I haven't been able to hit the conditions that others had, where I could observe a bug

Once we know how to cause the problem (having reproducible steps), it should be a quick fix 😄

There is a likely problem that will happen when you copy the profile between machines. Basically, macOS will use keychain to encrypt the passwords. Windows will use OS encryption to encrypt the passwords. If you copy the profile to another machine, the new machine is not able to decode the other passwords. I recently switched from macOS to Windows and my macOS passwords aren't showing in the saved passwords screen because of this problem. For these (copying profiles between machines or OSes), I don't think there's anything we can do until we have sync v2 w/ password syncing

[bsclifton]

Here's the Chromium code that will skip over entries in Login Data where it can't decrypt them:
https://source.chromium.org/chromium/chromium/src/+/master:components/password_manager/core/browser/login_database.cc;l=1962-1965;drc=dee6de248a7191cbad6023abd93d38c43a6e4d02?originalUrl=https:%2F%2Fcs.chromium.org%2F

I have a very old profile (upgraded over the years since 2016) and there are 162 logins stored in my Login Data DB (you can grab DB Browser for SQLite and view yourself, in the logins table. Need to quit Brave first to release the lock for the file). Of the 162 entries I've saved, 146 of them are not decryptable because I saved them on a different machine. This profile has bounced between 3 or 4 different machines and so the key used to encrypt the prior entries is not available on my current PC

This would explain why some passwords are not shown and may be the root cause for some folks. In my case, saving new passwords works fine and those show in the UI

[TripleSpeeder]

I have a very old profile (upgraded over the years since 2016) and there are 162 logins stored in my Login Data DB (you can grab DB Browser for SQLite and view yourself, in the logins table. Need to quit Brave first to release the lock for the file). Of the 162 entries I've saved, 146 of them are not decryptable because I saved them on a different machine. This profile has bounced between 3 or 4 different machines and so the key used to encrypt the prior entries is not available on my current PC

This would explain why some passwords are not shown and may be the root cause for some folks. In my case, saving new passwords works fine and those show in the UI

I have this problem on Arch Linux and never copied or migrated my profile once. At initial installation of brave I imported bookmarks, passwords etc. from Chromium and since then used Brave on this machine.

I can also confirm that initially the imported passwords were visible in Brave. I can not tell when this stopped working as i usually do not look up the passwords. I think i first noticed it around February this year.

[simonhong]

I think I found the cause of this issue and pushed PR(https://github.com/brave/brave-core/pull/5656)

Some users reported that Saved Passwords sections is empty but passwords are autofilled
to website's password form on linux and macOS.

I think this can happen if user insert/update new password entries after login db encryption is corrupted. However, currently user can't anything even if current login db has decryptable entries.

The reason is LoginDatabase::StatementToForms() gives empty password entry when any entry in
login db has decryption failure on linux and macOS.

To fix this, ENCRYPTION_RESULT_ITEM_FAILURE is returned for individual decryption failure
instead of ENCRYPTION_RESULT_SERVICE_FAILURE.

If ENCRYPTION_RESULT_SERVICE_FAILURE is returned, LoginDatabase::StatementToForms() assumes all other entries will have decrypt failure. However, db could have decryptable entries even if current entry is failed to decrypt.

Interestingly, this issue would not be happened on Windows because LoginDatabase::StatementToForms() returns decryptable entries(by using ENCRYPTION_RESULT_ITEM_FAILURE) returning instead of returning empty entry like other platform do.

[simonhong]

This would explain why some passwords are not shown and may be the root cause for some folks. In my case, saving new passwords works fine and those show in the UI

@bsclifton Maybe you uses Windows? Only Windows shows decryptable entries in Saved Passwords as I wrote in the above comment. :)

[matthewmarcus]

It's true I migrated from a PC to a Mac. And when I did, I copied the profiles from one computer to the other. Had no idea it would cause this issue tho.

So...

1) Is there a way to fix it? Even a manual fix using SQLite?

if not

2) What are next steps to get Brave working correctly again? Start from scratch? That would really blow.

Thanks for the help @bsclifton. It's reassuring that at least one dev is looking into the issue. I feared it might get lost in the mix and never receive attention.

[simonhong]

@matthewmarcus If you login any website and save pwd for it, brave will update login db with new one. Then, browser can autofill that site for you. but You still can't see them in settings page.
To see settings page now, you have to start with fresh db by deleting Login Data db file in your profile folder. Or, you can wait till my PR (https://github.com/brave/brave-core/pull/5656) is merged and applied to stable release. Then, you can see your newly added password entries in settings. Of course, your old passwords entries copied from other PC can't be visible though.

Please be sure that deleting Login Data file means you have to type again all your sites to login.

[simonhong]

@scorpion35 What makes you think this solution will work. The OS layer doesn't have anything to do with Brave application.

@matthewmarcus IMO, encryption key(that used to encrypt password) could be invalidated when system password is changed. But, not sure I didn't test this yet. If it's true, this scenario could be possible for making login db corrupted.

Changing system password on mac could make login db unusable - chromium on mac generates encryption key by using password - https://source.chromium.org/chromium/chromium/src/+/master:components/os_crypt/os_crypt_mac.mm;l=66

[bsclifton]

Nice work, @simonhong 😄 Testing out your PR right now. I suspect the same findings- anything that could invalidate the encryption key used (different keychain on macOS if you used Migration Assistant to move to a new machine, if you changes machines on Windows, etc) will result in PW not being shown. Weird that macOS has behavior where it'll stop parsing entries once a failure to decrypt is hit

@matthewmarcus two choices for a work-around I think:

1. You can delete the ~/Library/Application Support/BraveSoftware/Brave-Browser/Default/Login Data file and it should work fine on any future saved PWs 👍
2. Since you're on a mac, you can wait for https://github.com/brave/brave-core/pull/5656 to get reviewed/approved/merged and put into a next release (1.10, June 9th). Of course, it would be available in Beta or Nightly sooner but that would require moving your profile directory

[bsclifton]

@simonhong created a bug upstream - discussion taking place there with code owners:
https://bugs.chromium.org/p/chromium/issues/detail?id=1086348

[tangodev]

I'm so happy @bsclifton and @simonhong that the issue is getting more traction! :smile:

However: how does the encryption of the db relate to reinstalling / swapping PCs on Ubuntu Linux?

The first time I've noticed this issue was when I had a system crash and reinstalled. I restored my data from backups, but only Brave wasn't working correctly. Should I ensure that when I'm creating a new user profile in Ubuntu that I set the same user password? Or, does Brave use some hash that's unique to my installation and even if I take care to set the same Ubuntu user password, Brave will still fail to decrypt the db, because every single installation is unique in that regard?

A crash course on how this works (or a link to one) would be appreciated!

[matthewmarcus]

@bsclifton @simonhong - Thanks for your research and updates. Progress! Appreciate you guys.

So, to be clear, it's never going to be possible to view existing saved passwords, correct? Or is there something I can do (manually) to be able to see those once Simon's PR is included in the next release?

I downloaded and installed SQLite so I could view the Login Data file. Is there something I can do in there to make it possible to see all my passwords when the update is released?

[simonhong]

So, to be clear, it's never going to be possible to view existing saved passwords, correct? Or is there something I can do (manually) to be able to see those once Simon's PR is included in the next release?

@matthewmarcus If you delete Login Data file, you can see newly saved passwords after deletion.
If you don't delete, you can see newly saved passwords with my PR.

I downloaded and installed SQLite so I could view the Login Data file. Is there something I can do in there to make it possible to see all my passwords when the update is released?

I think there is no way to see your decryption failed pwd.

[simonhong]

However: how does the encryption of the db relate to reinstalling / swapping PCs on Ubuntu Linux?

I didn't see deeply about how encryption key is generated.
@tangodev If you have interests about how brave/chromium encrypt key for decrypting pwd in linux, GetEncryptionKey() is for you. :)

[matthewmarcus]

I think there is no way to see your decryption failed pwd.

Bummer. That is the biggest issue of all. I've probably got 200 saved passwords that are now pretty much lost. :-/

Would be cool if a dev could come up with a way to retrieve them. Even a hack. A lot of people dealing with this situation.

[simonhong]

@matthewmarcus If Brave autofills to passwords forms, you can see them and export them with my PR. Thant means you've updated passwords with current encryption key in login db. Other encrypted with old encryption key will not be used. I think it's hard to know the old encryption key.

[matthewmarcus]

Why was this issue closed? The problem still exists.

@simonhong I updated to the most recent release of Brave and tried to save a new password. It is not being displayed in brave://settings/passwords.

Was your PR included in the latest release?

Version 1.9.76 Chromium: 81.0.4044.138 (Official Build) (64-bit)

[simonhong]

@matthewmarcus This fix will currently available only for nightly channel(1.11.x).
You can get this fix when 1.11.x goes stable channel.

[LaurenWags]

Verified passed with macOS 10.14.6 Mojave using

Brave | 1.11.68 Chromium: 83.0.4103.106 (Official Build) dev (64-bit)
-- | --
Revision | ce7134bb3d95141cd18f1e65772a4247f282d950-refs/branch-heads/4103@{#694}
OS | macOS Version 10.14.6 (Build 18G3020)

• Verified test plan from https://github.com/brave/brave-core/pull/5656
• Reproduced the issue with 1.10.93 using steps from PR/test plan. Confirmed after copying the Chrome Login Data file, no passwords from that file were visible with 1.10.93. Added new passwords with 1.10.93 and confirmed they were not visible as per issue described. Upgraded to 1.11.68 and confirmed that passwords added with 1.10.93 were visible in brave://settings/passwords. Note - passwords copied from the Chrome Login Data file were still not visible (per https://github.com/brave/brave-browser/issues/3196#issuecomment-634374571). Also confirmed that adding new passwords using 1.11.68 were also visible on brave://settings/passwords.

cc @kjozwiak to check on macOS Catalina

---

Verified passed with Linux (Ubuntu 16.04) using

Brave   1.11.80 Chromium: 83.0.4103.116 (Official Build) dev (64-bit)
Revision    8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS  Linux

• Verified test plan from https://github.com/brave/brave-core/pull/5656

---

Verification PASSED on macOS 10.15.5 x64 Catalina using the following build:

Brave | 1.11.89 Chromium: 83.0.4103.116 (Official Build) dev (64-bit)
--- | ---
Revision | 8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS | macOS Version 10.15.5 (Build 19F101)

• Verified test plan from https://github.com/brave/brave-core/pull/5656
• Reproduced the issue with 1.10.93 using steps from PR/test plan. Confirmed after copying the Chrome Login Data file, no passwords from that file were visible with 1.10.93. Added new passwords with 1.10.93 and confirmed they were not visible as per issue described. Upgraded to 1.11.68 and confirmed that passwords added with 1.10.93 were visible in brave://settings/passwords. Note - passwords copied from the Chrome Login Data file were still not visible (per https://github.com/brave/brave-browser/issues/3196#issuecomment-634374571). Also confirmed that adding new passwords using 1.11.68 were also visible on brave://settings/passwords.

[Psijic]

Can't see saved passwords in Brave, Linux OpenSUSE 15.2
1.10.97 Chromium: 83.0.4103.116 (64-bit)

All is ok with 1.11.97 Chromium: 84.0.4147.89

[TripleSpeeder]

Finally got 1.11.97 on Arch linux and rejoice, passwords are there! Thanks guys :+1:

[matthewmarcus]

Finally got 1.11.97 on Arch linux and rejoice, passwords are there! Thanks guys 👍

Same! I just updated Brave and can see all of my passwords. Not just recently saved ones, but all of them. So, how did y'all get around the encrypted DB issue? I understood that we'd never be able to see old saved passwords. Just new ones after the fix was implemented.

Regardless, thank you for implementing this fix! Much gratitude and many kudos.

[sd0minick]

Is this fix implemented only for Arch Linux users?

On Thu, Jul 23, 2020 at 3:05 PM Matthew W. Marcus [e-mail]
wrote:

Finally got 1.11.97 on Arch linux and rejoice, passwords are there! Thanks
guys 👍

Same! I just updated Brave and can see all of my passwords. Not just
recently saved ones, but all of them. So, how did y'all get around the
encrypted DB issue? I understood that we'd never be able to see old saved
passwords. Just new ones after the fix was implemented.

Regardless, thank you for implementing this fix! Much gratitude and many
kudos.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/brave/brave-browser/issues/3196#issuecomment-663180407,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJXTXDM27YL6MFSHCQQ7T5LR5CCXFANCNFSM4GT5XUXA
.

--
Steeve DOMINIQUE

[kjozwiak]

Is this fix implemented only for Arch Linux users?

It was also fixed on macOS 👍 If you take a look at the labels, you'll notice the issue has both OS/Linux and OS/macOS which indicates the affected platforms. We also QA'd and verified the fix on both Linux & macOS as per https://github.com/brave/brave-browser/issues/3196#issuecomment-645998836.