Brave-browser: Option to hide Brave Shields activity count

Created on 27 Jan 2019  路  16Comments  路  Source: brave/brave-browser

Test plan

See https://github.com/brave/brave-core/pull/3150

Description

Some people think the incrementing block count on Brave Shields is distracting.

The color of the icon is enough for me to know whether it's enabled or not, and if it's enabled I trust that it's working. I'm happy to click the icon if I need more details, but that's rare.

Provide the option to hide the block count while still keeping the shields up.

Designs

Add "Indicate the number of blocked items on the Shields icon" to Shields settings:

shields hide block count indicator

It will be toggled ON by default. If the user toggles the indicator OFF, the Shields icon will not have the incrementing blocked item counter, but will still be colored when it's enabled.

QA Pass-Linux QA Pass-Win64 QA Pass-macOS QTest-Plan-Specified QYes browser-laptop-parity featurglobal-settings featurshields prioritP3 release-noteinclude

Most helpful comment

+1 - please devs, give us an option to hide that counter and a seperate option to hide the lion icon. It's useless for me, and IMHO not aesthetic all in all. Less is more.

All 16 comments

This feature used to be available with Brave Muon: brave/browser-laptop#8613, brave/browser-laptop#8701

Label: browser-laptop-parity

+1.

The count being displayed is horrible for somebody with OCD tendencies (like me). It constantly makes me feel like there are some open notifications I'm supposed to handle 馃槥

+1 - please devs, give us an option to hide that counter and a seperate option to hide the lion icon. It's useless for me, and IMHO not aesthetic all in all. Less is more.

+1

+1

+1 all popular ad blockers have option to hide blocked items counter, that's very surprising brave browser doesn't have that. that counter is super distracting, so actually brave browser isn't usable for me while there is no option to hide it

+1 all popular ad blockers have option to hide blocked items counter, that's very surprising brave browser doesn't have that. that counter is super distracting, so actually brave browser isn't usable for me while there is no option to hide it

Echo this. Completely unusable without this option. Back to Firefox for time being.

Designs added @tomlowenthal

Can I ask what P3 backlog means in terms of timelines? This is incredibly distracting to me too and I would love to know if this is going to be updated soon after I just migrated everything from Chrome.

@caroltoo hard to estimate a timeline, but this issue is definitely on our radar and we do want to fix it 馃槃 I don't think it would be a terribly difficult change to make (we'd just need to set aside the time to do it)

Time to fork guys.

Hi, how do I put this setting into my Brave browser? I am not good with Github, I don't know how to apply these kind of settings.
Thanks.

@igekaratas thanks for your patience; we're reviewing now and should be able to merge a fix for this soon 馃槃

Verification passed on

Brave | 1.7.67 Chromium: 80.0.3987.149聽(Official Build)聽beta聽(64-bit)
-- | --
Revision | 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS | Windows聽10 OS Version 1803 (Build 17134.1006)

  • Verified the test plan from https://github.com/brave/brave-core/pull/3150
  • Verified Show the number of blocked items on the Shields icon works as expected when toggling OFF/ON
  • Verified that changes are reflected across all the tabs in Normal Tab/Private Tab/Private tab with Tor
  • Verified in both clean and upgraded profiles
    image

Verification passed on

Brave | 1.7.71 Chromium: 80.0.3987.149聽(Official Build)聽dev聽(64-bit)
-- | --
Revision | 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS | Ubuntu 18.04 LTS

  • Verified the test plan from https://github.com/brave/brave-core/pull/3150
  • Verified Show the number of blocked items on the Shields icon works as expected when toggling OFF/ON
  • Verified that changes are reflected across all the tabs in Normal Tab/Private Tab/Private tab with Tor
  • Verified in both clean and upgraded profiles

image

Verification PASSED on macOS 10.15.3 x64 Catalina using the following build:

Brave | 1.7.79 Chromium: 80.0.3987.149聽(Official Build)聽dev聽(64-bit)
-- | --
Revision | 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS | macOS Version 10.15.3 (Build 19D76)
  • verified the STR/Cases outlined via https://github.com/brave/brave-core/pull/3150#issue-306423831
  • ensured that Show the number of blocked items on the Shields icon is enabled by default
  • ensured that disabling Show the number of blocked items on the Shields icon affects currently opened tabs + newly created tabs
  • ensured that disabling/enabling Show the number of blocked items on the Shields icon doesn't affect current shield settings
  • ensured that the Show the number of blocked items on the Shields icon setting is remembered when restarting the browser
  • ensured the feature works under PB and Tor windows
  • ensured that upgrading from 1.5.115 CR: 80.0.3987.149 worked as expected

Screen Shot 2020-03-31 at 1 01 28 PM

Brave is now usable. Switched.

Was this page helpful?
0 / 5 - 0 ratings