Brave-browser: Regular stub installer does not send download-complete and installer-run pings

[btlechowski]

Steps to Reproduce

1. Uninstall Brave though Control Panel
2. Delete Download and Install from c:\Program Files (x86)\BraveSoftware\Update\
3. Prepare Fiddler as described in https://github.com/brave/brave-browser/issues/2784#issuecomment-453298218
   
   
   
   1. Run regular stub installer (BraveBrowserSetup.exe)
   
   

Actual result:

Only startup ping is sent
Pings download-complete and installer-run are not sent

Expected result:

All 3 pings are sent

Reproduces how often:

always

Brave version (brave://version info)

Brave | 0.58.20 Chromium: 71.0.3578.98 (Official Build) (64-bit)
-- | --
Revision | 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS | Windows 7

Also reproduced on Windows 10 x64

cc @emerick @brave/legacy_qa

[emerick]

@btlechowski I would check if @aubrey can possibly pull the server logs for those requests, it could just be a hiccup in Fiddler. I only ever ran and tested with the regular (non-silent) installer, so it would be weird if it wasn't working (and I even downloaded the release candidate regular stub installer today and confirmed that it sent all three pings).

[emerick]

@simonhong I'll investigate in the morning, but any thoughts why there could be a difference here between the regular stub installer and the silent one?

[simonhong]

Hmm, it's strange. need to check.
stub & silent installer all downloads brave installer from update server and installs.

[emerick]

Spoke with @simonhong and it seems to occur when performing an admin install. When you receive the UAC prompt, if you choose "Yes" it will do an admin install and if you choose "No" it will do a non-admin install. It seems that the admin install leads to this problem.

[emerick]

Upon further investigation, it seems to be related to trying to read the app guid out of the registry when running in admin mode; the key isn't there. We don't need to store the app_guid in the registry, since we have access to the app_guid in the app bundle. So we can fix this problem. But, we also read the referral code from the registry and there is no clear way around that.

@bbondy Just a heads up on this one.

[kjozwiak]

@btlechowski nice find 👍

@bbondy I don't think this is a blocker for tomorrow's release but let me know what you think. If we end up deciding on blocking, we'll need to release Monday morning. Unless we get this fixed today/tomorrow AM and release sometime Friday afternoon.

[bbondy]

let's not block

[emerick]

We won't consult the registry at all in order to avoid this problem. For the app guid, we'll parse it out of the tag in the metainstaller and we'll access it via the app pointer. For the referral code, we'll parse it out of our filename as always and then append it to the tag that we forward to the installer (again accessing it via the app pointer, since Omaha already supports the concept of a referral id).

[emerick]

@btlechowski I discovered an easier way to debug this, when the time comes. If you create a file named c:\BraveUpdate.ini with the correct settings (may need to use admin privileges to write to that location), Omaha will log all relevant information to C:\ProgramData\BraveSoftware\Update\Log\BraveUpdate.log including the requests and responses associated with the Brave server. I'll attach the .ini file that I used for testing, although note that I had to zip it to add it here.

BraveUpdate.zip

[btlechowski]

Verification passed on

Brave | 0.59.26 Chromium: 72.0.3626.64 (Official Build) beta (64-bit)
-- | --
Revision | eaa9668e80ce5405e7f1902579558ea725c06ca1-refs/branch-heads/3626@{#708}
OS | Windows

Summery:
Windows 10 x64 full PASS
Windows 7 x64 initiates the pings, but there is a server error (reproduces on production server, but not on staging). Reported https://github.com/brave/brave-browser/issues/3030

[PASS - initiates pings] Windows 7 x64, BraveBrowserBetaSetup-OJV851.exe with whitelisted ref code

[01/21/19 05:08:34.809][BraveBrowserBetaSetup-OJV851][7676:10928][Send][url=https://laptop-updates.brave.com/1/installerEvent?platform=winx64-bc&version=0.0.0&channel=beta&ref=OJV851&event=startup][request=][filename=]
[01/21/19 05:08:36.218][BraveBrowserBetaSetup-OJV851][7676:10928][Send response received][result 0x80072f8f][status code 0][]
[01/21/19 05:09:39.705][BraveUpdate:goopdate][8592:9032][Send][url=https://laptop-updates.brave.com/1/installerEvent?platform=winx64-bc&version=0.59.26&channel=beta&ref=OJV851&event=download-complete][request=][filename=]
[01/21/19 05:09:41.075][BraveUpdate:goopdate][8592:9032][Send response received][result 0x80072f8f][status code 0][]
[01/21/19 05:10:04.083][BraveUpdate:goopdate][8592:9032][Send][url=https://laptop-updates.brave.com/1/installerEvent?platform=winx64-bc&version=0.59.26&channel=beta&ref=OJV851&event=installer-run][request=][filename=]
[01/21/19 05:10:05.412][BraveUpdate:goopdate][8592:9032][Send response received][result 0x80072efd][status code 0][]

[PASS - initiates pings] Windows 7 x64, BraveBrowserSilentBetaSetup-ZTT758.exe with admin privileges, with whitelisted ref code

[01/21/19 03:16:29.136][BraveBrowserSilentBetaSetup-ZTT758][3792:6060][Send][url=https://laptop-updates.brave.com/1/installerEvent?platform=winx64-bc&version=0.0.0&channel=beta&ref=ZTT758&event=startup][request=][filename=]
[01/21/19 03:16:29.854][BraveBrowserSilentBetaSetup-ZTT758][3792:6060][Send response received][result 0x80072efe][status code 0][]
[01/21/19 03:17:53.427][BraveUpdate:goopdate][1128:8688][Send][url=https://laptop-updates.brave.com/1/installerEvent?platform=winx64-bc&version=0.59.26&channel=beta&ref=ZTT758&event=download-complete][request=][filename=]
[01/21/19 03:17:53.910][BraveUpdate:goopdate][1128:8688][Send response received][result 0x80072efe][status code 0][]
[01/21/19 03:18:03.115][BraveUpdate:goopdate][1128:8688][Send][url=https://laptop-updates.brave.com/1/installerEvent?platform=winx64-bc&version=0.59.26&channel=beta&ref=ZTT758&event=installer-run][request=][filename=]
[01/21/19 03:18:03.599][BraveUpdate:goopdate][1128:8688][Send response received][result 0x80072efe][status code 0][]

[PASS] Windows 10 x64, BraveBrowserBetaSetup.exe with admin privileges, with no ref code

[01/21/19 03:36:16.103][BraveBrowserBetaSetup][16624:3272][Send][url=https://laptop-updates.brave.com/1/installerEvent?platform=winx64-bc&version=0.0.0&channel=beta&ref=none&event=startup][request=][filename=]
[01/21/19 03:36:16.791][BraveBrowserBetaSetup][16624:3272][Send response received][result 0x0][status code 200][{"ts":1548038173875,"status":"ok"}]
[01/21/19 03:37:12.281][BraveUpdate:goopdate][10008:17236][Send][url=https://laptop-updates.brave.com/1/installerEvent?platform=winx64-bc&version=0.59.26&channel=beta&ref=none&event=download-complete][request=][filename=]
[01/21/19 03:37:12.611][BraveUpdate:goopdate][10008:17236][Send response received][result 0x0][status code 200][{"ts":1548038229681,"status":"ok"}]
[01/21/19 03:37:13.017][BraveUpdate:goopdate][10008:17236][Send][url=https://laptop-updates.brave.com/1/installerEvent?platform=winx64-bc&version=0.59.26&channel=beta&ref=none&event=installer-run][request=][filename=]
[01/21/19 03:37:14.643][BraveUpdate:goopdate][10008:17236][Send response received][result 0x0][status code 200][{"ts":1548038231718,"status":"ok"}]

[PASS] Windows 10 x64, BraveBrowserBetaSetup-BLE123.exe with admin privileges, with unwhitelisted ref code

[01/21/19 03:44:21.275][BraveBrowserBetaSetup-BLE123][4000:2052][Send][url=https://laptop-updates.brave.com/1/installerEvent?platform=winx64-bc&version=0.0.0&channel=beta&ref=none&event=startup][request=][filename=]
[01/21/19 03:44:21.619][BraveBrowserBetaSetup-BLE123][4000:2052][Send response received][result 0x0][status code 200][{"ts":1548038658696,"status":"ok"}]
[01/21/19 03:45:15.475][BraveUpdate:goopdate][6656:8412][Send][url=https://laptop-updates.brave.com/1/installerEvent?platform=winx64-bc&version=0.59.26&channel=beta&ref=none&event=download-complete][request=][filename=]
[01/21/19 03:45:15.788][BraveUpdate:goopdate][6656:8412][Send response received][result 0x0][status code 200][{"ts":1548038712859,"status":"ok"}]
[01/21/19 03:45:16.195][BraveUpdate:goopdate][6656:8412][Send][url=https://laptop-updates.brave.com/1/installerEvent?platform=winx64-bc&version=0.59.26&channel=beta&ref=none&event=installer-run][request=][filename=]
[01/21/19 03:45:17.854][BraveUpdate:goopdate][6656:8412][Send response received][result 0x0][status code 200][{"ts":1548038714920,"status":"ok"}]

[PASS] Windows 10 x64, BraveBrowserBetaSetup-MTS962.exe with admin privileges, with whitelisted ref code

[01/21/19 03:39:42.919][BraveBrowserBetaSetup-MTS962][14964:10184][Send][url=https://laptop-updates.brave.com/1/installerEvent?platform=winx64-bc&version=0.0.0&channel=beta&ref=MTS962&event=startup][request=][filename=]
[01/21/19 03:39:43.278][BraveBrowserBetaSetup-MTS962][14964:10184][Send response received][result 0x0][status code 200][{"ts":1548038380350,"status":"ok"}]
[01/21/19 03:40:35.289][BraveUpdate:goopdate][7140:4908][Send][url=https://laptop-updates.brave.com/1/installerEvent?platform=winx64-bc&version=0.59.26&channel=beta&ref=MTS962&event=download-complete][request=][filename=]
[01/21/19 03:40:35.617][BraveUpdate:goopdate][7140:4908][Send response received][result 0x0][status code 200][{"ts":1548038432685,"status":"ok"}]
[01/21/19 03:40:36.023][BraveUpdate:goopdate][7140:4908][Send][url=https://laptop-updates.brave.com/1/installerEvent?platform=winx64-bc&version=0.59.26&channel=beta&ref=MTS962&event=installer-run][request=][filename=]
[01/21/19 03:40:37.652][BraveUpdate:goopdate][7140:4908][Send response received][result 0x0][status code 200][{"ts":1548038434731,"status":"ok"}]

[PASS] Windows 10 x64, BraveBrowserBetaSetup-MTS962.exe with no admin privileges, with whitelisted ref code

[01/21/19 03:50:18.557][BraveBrowserBetaSetup-MTS962][15280:6664][Send][url=https://laptop-updates.brave.com/1/installerEvent?platform=winx64-bc&version=0.0.0&channel=beta&ref=MTS962&event=startup][request=][filename=]
[01/21/19 03:50:19.261][BraveBrowserBetaSetup-MTS962][15280:6664][Send response received][result 0x0][status code 200][{"ts":1548039016323,"status":"ok"}]
[01/21/19 03:51:14.177][BraveUpdate:goopdate][16996:13300][Send][url=https://laptop-updates.brave.com/1/installerEvent?platform=winx64-bc&version=0.59.26&channel=beta&ref=MTS962&event=download-complete][request=][filename=]
[01/21/19 03:51:14.521][BraveUpdate:goopdate][16996:13300][Send response received][result 0x0][status code 200][{"ts":1548039071586,"status":"ok"}]
[01/21/19 03:51:14.943][BraveUpdate:goopdate][16996:13300][Send][url=https://laptop-updates.brave.com/1/installerEvent?platform=winx64-bc&version=0.59.26&channel=beta&ref=MTS962&event=installer-run][request=][filename=]
[01/21/19 03:51:15.083][BraveUpdate:goopdate][16996:13300][Send response received][result 0x0][status code 200][{"ts":1548039072147,"status":"ok"}]

Note: after install, two windows were shown instead of one

[PASS] Windows 10 x64, BraveBrowserSilentBetaSetup-BLE321.exe with unwhitelisted ref code

[01/21/19 04:10:54.949][BraveBrowserSilentBetaSetup-BLE321][4472:12280][Send][url=https://laptop-updates.brave.com/1/installerEvent?platform=winx64-bc&version=0.0.0&channel=beta&ref=none&event=startup][request=][filename=]
[01/21/19 04:10:55.652][BraveBrowserSilentBetaSetup-BLE321][4472:12280][Send response received][result 0x0][status code 200][{"ts":1548040252703,"status":"ok"}]
[01/21/19 04:11:47.657][BraveUpdate:goopdate][12312:17184][Send][url=https://laptop-updates.brave.com/1/installerEvent?platform=winx64-bc&version=0.59.26&channel=beta&ref=none&event=download-complete][request=][filename=]
[01/21/19 04:11:47.985][BraveUpdate:goopdate][12312:17184][Send response received][result 0x0][status code 200][{"ts":1548040305035,"status":"ok"}]
[01/21/19 04:11:48.407][BraveUpdate:goopdate][12312:17184][Send][url=https://laptop-updates.brave.com/1/installerEvent?platform=winx64-bc&version=0.59.26&channel=beta&ref=none&event=installer-run][request=][filename=]
[01/21/19 04:11:48.861][BraveUpdate:goopdate][12312:17184][Send response received][result 0x0][status code 200][{"ts":1548040305911,"status":"ok"}]

[PASS] Windows 10 x64, BraveBrowserSilentBetaSetup-MTS962.exe with whitelisted ref code

[01/21/19 04:14:22.342][BraveBrowserSilentBetaSetup-MTS962][11096:4740][Send][url=https://laptop-updates.brave.com/1/installerEvent?platform=winx64-bc&version=0.0.0&channel=beta&ref=MTS962&event=startup][request=][filename=]
[01/21/19 04:14:22.717][BraveBrowserSilentBetaSetup-MTS962][11096:4740][Send response received][result 0x0][status code 200][{"ts":1548040459761,"status":"ok"}]
[01/21/19 04:15:10.111][BraveUpdate:goopdate][16996:1248][Send][url=https://laptop-updates.brave.com/1/installerEvent?platform=winx64-bc&version=0.59.26&channel=beta&ref=MTS962&event=download-complete][request=][filename=]
[01/21/19 04:15:10.754][BraveUpdate:goopdate][16996:1248][Send response received][result 0x0][status code 200][{"ts":1548040507803,"status":"ok"}]
[01/21/19 04:15:11.192][BraveUpdate:goopdate][16996:1248][Send][url=https://laptop-updates.brave.com/1/installerEvent?platform=winx64-bc&version=0.59.26&channel=beta&ref=MTS962&event=installer-run][request=][filename=]
[01/21/19 04:15:11.661][BraveUpdate:goopdate][16996:1248][Send response received][result 0x0][status code 200][{"ts":1548040508694,"status":"ok"}]

[PASS] Windows 10 x64, BraveBrowserBetaSetup32.exe with admin privileges, with no ref code

[01/21/19 03:55:18.124][BraveBrowserBetaSetup32][14860:17168][Send][url=https://laptop-updates.brave.com/1/installerEvent?platform=winx64-bc&version=0.0.0&channel=beta&ref=none&event=startup][request=][filename=]
[01/21/19 03:55:18.484][BraveBrowserBetaSetup32][14860:17168][Send response received][result 0x0][status code 200][{"ts":1548039315545,"status":"ok"}]
[01/21/19 03:56:09.893][BraveUpdate:goopdate][10452:16996][Send][url=https://laptop-updates.brave.com/1/installerEvent?platform=winx64-bc&version=0.59.26&channel=beta&ref=none&event=download-complete][request=][filename=]
[01/21/19 03:56:10.534][BraveUpdate:goopdate][10452:16996][Send response received][result 0x0][status code 200][{"ts":1548039367598,"status":"ok"}]
[01/21/19 03:56:10.925][BraveUpdate:goopdate][10452:16996][Send][url=https://laptop-updates.brave.com/1/installerEvent?platform=winx64-bc&version=0.59.26&channel=beta&ref=none&event=installer-run][request=][filename=]
[01/21/19 03:56:12.553][BraveUpdate:goopdate][10452:16996][Send response received][result 0x0][status code 200][{"ts":1548039369612,"status":"ok"}]

[PASS] Windows 10 x64, BraveBrowserBetaSetup32-BLE871.exe with admin privileges, with unwhitelisted ref code

[01/21/19 03:59:20.630][BraveBrowserBetaSetup32-BLE871][17320:15700][Send][url=https://laptop-updates.brave.com/1/installerEvent?platform=winx64-bc&version=0.0.0&channel=beta&ref=none&event=startup][request=][filename=]
[01/21/19 03:59:21.288][BraveBrowserBetaSetup32-BLE871][17320:15700][Send response received][result 0x0][status code 200][{"ts":1548039558342,"status":"ok"}]
[01/21/19 04:00:12.855][BraveUpdate:goopdate][12164:13224][Send][url=https://laptop-updates.brave.com/1/installerEvent?platform=winx64-bc&version=0.59.26&channel=beta&ref=none&event=download-complete][request=][filename=]
[01/21/19 04:00:13.543][BraveUpdate:goopdate][12164:13224][Send response received][result 0x0][status code 200][{"ts":1548039610599,"status":"ok"}]
[01/21/19 04:00:13.934][BraveUpdate:goopdate][12164:13224][Send][url=https://laptop-updates.brave.com/1/installerEvent?platform=winx64-bc&version=0.59.26&channel=beta&ref=none&event=installer-run][request=][filename=]
[01/21/19 04:00:15.575][BraveUpdate:goopdate][12164:13224][Send response received][result 0x0][status code 200][{"ts":1548039612629,"status":"ok"}]

[PASS] Windows 10 x64, BraveBrowserBetaSetup32-MTS962.exe with admin privileges, with whitelisted ref code

[01/21/19 04:03:24.880][BraveBrowserBetaSetup32-MTS962][3040:8548][Send][url=https://laptop-updates.brave.com/1/installerEvent?platform=winx64-bc&version=0.0.0&channel=beta&ref=MTS962&event=startup][request=][filename=]
[01/21/19 04:03:25.552][BraveBrowserBetaSetup32-MTS962][3040:8548][Send response received][result 0x0][status code 200][{"ts":1548039802612,"status":"ok"}]
[01/21/19 04:04:14.455][BraveUpdate:goopdate][12852:8620][Send][url=https://laptop-updates.brave.com/1/installerEvent?platform=winx64-bc&version=0.59.26&channel=beta&ref=MTS962&event=download-complete][request=][filename=]
[01/21/19 04:04:15.096][BraveUpdate:goopdate][12852:8620][Send response received][result 0x0][status code 200][{"ts":1548039852150,"status":"ok"}]
[01/21/19 04:04:15.502][BraveUpdate:goopdate][12852:8620][Send][url=https://laptop-updates.brave.com/1/installerEvent?platform=winx64-bc&version=0.59.26&channel=beta&ref=MTS962&event=installer-run][request=][filename=]
[01/21/19 04:04:17.128][BraveUpdate:goopdate][12852:8620][Send response received][result 0x0][status code 200][{"ts":1548039854179,"status":"ok"}]

[PASS] Windows 10 x64, BraveBrowserBetaSetup32-MTS962.exe with no admin privileges, with whitelisted ref code

[01/21/19 04:06:24.757][BraveBrowserBetaSetup32-MTS962][15668:2264][Send][url=https://laptop-updates.brave.com/1/installerEvent?platform=winx64-bc&version=0.0.0&channel=beta&ref=MTS962&event=startup][request=][filename=]
[01/21/19 04:06:25.413][BraveBrowserBetaSetup32-MTS962][15668:2264][Send response received][result 0x0][status code 200][{"ts":1548039982461,"status":"ok"}]
[01/21/19 04:07:15.957][BraveUpdate:goopdate][13864:7164][Send][url=https://laptop-updates.brave.com/1/installerEvent?platform=winx64-bc&version=0.59.26&channel=beta&ref=MTS962&event=download-complete][request=][filename=]
[01/21/19 04:07:16.271][BraveUpdate:goopdate][13864:7164][Send response received][result 0x0][status code 200][{"ts":1548040033330,"status":"ok"}]
[01/21/19 04:07:16.677][BraveUpdate:goopdate][13864:7164][Send][url=https://laptop-updates.brave.com/1/installerEvent?platform=winx64-bc&version=0.59.26&channel=beta&ref=MTS962&event=installer-run][request=][filename=]
[01/21/19 04:07:17.130][BraveUpdate:goopdate][13864:7164][Send response received][result 0x0][status code 200][{"ts":1548040034184,"status":"ok"}]

Note: after install, two windows were shown instead of one

[PASS] Windows 10 x64, BraveBrowserSilentBetaSetup32-BLE631.exe with unwhitelisted ref code

[01/21/19 04:17:50.634][BraveBrowserSilentBetaSetup32-BLE631][5404:8836][Send][url=https://laptop-updates.brave.com/1/installerEvent?platform=winx64-bc&version=0.0.0&channel=beta&ref=none&event=startup][request=][filename=]
[01/21/19 04:17:50.993][BraveBrowserSilentBetaSetup32-BLE631][5404:8836][Send response received][result 0x0][status code 200][{"ts":1548040668032,"status":"ok"}]
[01/21/19 04:18:40.133][BraveUpdate:goopdate][13088:17380][Send][url=https://laptop-updates.brave.com/1/installerEvent?platform=winx64-bc&version=0.59.26&channel=beta&ref=none&event=download-complete][request=][filename=]
[01/21/19 04:18:40.790][BraveUpdate:goopdate][13088:17380][Send response received][result 0x0][status code 200][{"ts":1548040717837,"status":"ok"}]
[01/21/19 04:18:41.181][BraveUpdate:goopdate][13088:17380][Send][url=https://laptop-updates.brave.com/1/installerEvent?platform=winx64-bc&version=0.59.26&channel=beta&ref=none&event=installer-run][request=][filename=]
[01/21/19 04:18:41.322][BraveUpdate:goopdate][13088:17380][Send response received][result 0x0][status code 200][{"ts":1548040718370,"status":"ok"}]

[PASS] Windows 10 x64, BraveBrowserSilentBetaSetup32-MTS962.exe with whitelisted ref code

[01/21/19 04:20:23.293][BraveBrowserSilentBetaSetup32-MTS962][16972:14852][Send][url=https://laptop-updates.brave.com/1/installerEvent?platform=winx64-bc&version=0.0.0&channel=beta&ref=MTS962&event=startup][request=][filename=]
[01/21/19 04:20:23.982][BraveBrowserSilentBetaSetup32-MTS962][16972:14852][Send response received][result 0x0][status code 200][{"ts":1548040821022,"status":"ok"}]
[01/21/19 04:21:09.046][BraveUpdate:goopdate][16772:9504][Send][url=https://laptop-updates.brave.com/1/installerEvent?platform=winx64-bc&version=0.59.26&channel=beta&ref=MTS962&event=download-complete][request=][filename=]
[01/21/19 04:21:09.671][BraveUpdate:goopdate][16772:9504][Send response received][result 0x0][status code 200][{"ts":1548040866721,"status":"ok"}]
[01/21/19 04:21:10.077][BraveUpdate:goopdate][16772:9504][Send][url=https://laptop-updates.brave.com/1/installerEvent?platform=winx64-bc&version=0.59.26&channel=beta&ref=MTS962&event=installer-run][request=][filename=]
[01/21/19 04:21:10.218][BraveUpdate:goopdate][16772:9504][Send response received][result 0x0][status code 200][{"ts":1548040867264,"status":"ok"}]

[kjozwiak]

Awesome work @btlechowski 👍