Brave-browser: "Join" extension won't function in Brave

Created on 7 Dec 2018  ·  9Comments  ·  Source: brave/brave-browser

Description


Several users have brought to my attention that apps like "Join" won't work in Brave with #1380.
Devices cannot communicate and device the extension is installed on remains "unrecognized". Diagnostics in the extension show the following errors:
image

Steps to Reproduce

  1. Install Join extension
  2. Try to use the extension
  3. When it doesn't work, run diagnostics

Actual result:


Extension doesn't function

Expected result:

Extension should work and device should be recognized.

Reproduces how often:


Easily/always

Brave version (brave://version info)


All current builds
Release Build v0.57.18
Beta build v0.57.8
Developer build v0.59.2

Reproducible on current release:

Yes

  • Does it reproduce on brave-browser dev/beta builds?
    Yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
    No
  • Is the issue reproducible on the latest version of Chrome?
    No

Additional Information


No Shields settings, in domain-specific or global, have any effect.

bug featurextensions featurshieldwebcompat needs-more-info prioritP5

Most helpful comment

This is still an issue with the latest version of the browser (0.60.47 Chromium: 72.0.3626.119 (Official Build) (64-bit)). Anything I can do to help get this resolved faster? Basically, the only thing preventing me from switching fully to Brave.

All 9 comments

This is still an issue with the latest version of the browser (0.60.47 Chromium: 72.0.3626.119 (Official Build) (64-bit)). Anything I can do to help get this resolved faster? Basically, the only thing preventing me from switching fully to Brave.

This is still an issue with the latest version of the browser (0.60.47 Chromium: 72.0.3626.119 (Official Build) (64-bit)). Anything I can do to help get this resolved faster? Basically, the only thing preventing me from switching fully to Brave.

FWIW - When I started collecting errors on the extension it failed on line 1963 with the following error: Error: File doesn't exist on your google drive: storedpushes=:=undefined.

In addition, when you run through the GCM Internals the connection state comes up as false.

I haven't spent a lot of time on this issue, but in my case it acts like it's not integrated with Google Drive even though I went through the setup. I've only been able to reproduce this issue in Brave. Going through setup in Chrome and Canary still works.

Hey, if it helps:
If you go to Join's chrome extension store page, in the "Support" tab, the user Sean Blonien posted 2 days ago (so Apr. 27 2019):
image
So it looks like the problem is related to regId?

+1 I rely on this extension quite a bit.

+1

It's working perfectly now in Brave Dev Version 0.72.110 Chromium: 78.0.3904.70 after enabling Use Google Services for Push Messaging (Added in v0.72.73 - https://github.com/brave/brave-browser/issues/2301 / https://github.com/brave/brave-core/pull/3390 / https://github.com/brave/brave-core/commit/cd3df93236f9677a70493e4cc1a82ba6d5bfb973) . This finally enables Brave to work with Firebase Cloud Messaging, after GCM having been deprecated earlier this year (more info: GCM/FCM FAQ).
_Note: This feature isn't available yet in Release/Beta channels._

There appears to be a bug though, where clicking the Relaunch button after toggling it on, untoggles the setting before relaunching. I got around this by toggling it on, and then running chrome://restart in a new tab. I've created https://github.com/brave/brave-browser/issues/6633 for the bug.

  • [x] Step 1: Use Google Services for Push Messaging :feelsgood:
  • [ ] Step 2: ‽‽‽‽‽
  • [x] Step 3: Profit!!! :money_mouth_face::money_with_wings:

Can confirm, Join works great in Brave now. You just need to enable Google Services for Push Messaging as @LesterCovax showed. I'm on the Release channel, so it looks like this feature has made its way there.

Join has a self-test function under the diagnostics tab. All the tests pass in Brave 🎉

A screenshot of Join's diagnostics tab, taken after running the tests in Brave. All the tests have passed.

Tested on Version 1.1.23 Chromium: 79.0.3945.88 (Official Build) (64-bit).

Thanks for confirming, folks! 😄

Was this page helpful?
0 / 5 - 0 ratings