Brave-browser: Tip not shown in Summary on settings page when Payments data imported from muon

[LaurenWags]

Description

If you import Payments data from muon, and then tip a site (one time tip), the tip does not display in your Rewards Summary. Instead, you see the 'Sadly, no tokens' message.

Steps to Reproduce

1. Have Payments set up in muon (wallet with balance, etc)
2. Import data to b-c.
3. See data successfully import to b-c (wallet balance, pinned sites become tips, etc)
4. Navigate to a site and do a one time tip.
5. Wallet balance goes down, tip is recorded in Tips panel (other tips were imported) - see tip highlighted in box:
   

Actual result:

Tip is not recorded in Rewards Summary on brave://rewards or via the BAT logo:

Expected result:

Tip should be recorded in summary.

Reproduces how often:

easily

Brave version (brave://version info)

Brave | 0.57.16 Chromium: 71.0.3578.80 (Official Build) (64-bit)
-- | --
Revision | 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS | Mac OS X

Reproducible on current release:

• Does it reproduce on brave-browser dev/beta builds?

Website problems only:

• Does the issue resolve itself when disabling Brave Shields?
• Is the issue reproducible on the latest version of Chrome?

Additional Information

If you perform the steps with a fresh wallet created on 0.57.x (not imported from muon), the tip displays in the Rewards Summary:

[LaurenWags]

cc @NejcZdovc @bsclifton @rebron @kjozwiak

[kjozwiak]

@LaurenWags do you know if there's a way to recover from this state once a user runs into this issue? I think I remember you mentioning that you never ended up seeing anything in the summary. If there's no way of recovering, I think this is a high priority as we'll have a large % of users stuck in this state eventually.

@rebron @bsclifton if there's a hotfix being planned before we do another phase of migrations, this should be at least investigated IMO. @LaurenWags thoughts?

[LaurenWags]

@kjozwiak I don't believe there's a way to recover from this state. I agree that we should up the priority so upgraded users get an accurate picture of what's going on in Rewards - especially since this is a new feature not available in Payments. Also, it could be related to https://github.com/brave/brave-browser/issues/2379

[kjozwiak]

@rebron moved this into 0.58.x as per our conversation with @davidtemkin. Can we get someone to take a look at this? Once someone is assigned, lets move it out of Untriaged Backlog in Rewards and into the In Progress board 👍

[NejcZdovc]

@kjozwiak I will take a look later today

[rebron]

@LaurenWags Does this happen when you manually import payments from muon (or was this from the auto update)?

[LaurenWags]

@rebron - reproduces when auto updating from muon, manually importing (thru Import Bookmarks and Settings), and launching brave with --update-from-muon flag in terminal.

[kjozwiak]

@LaurenWags thanks for double checking 👍

@rebron definitely need to get this fixed as we're encouraging users to migrate their date over. @NejcZdovc mentioned that he'll be looking at this so hopefully we can get this fixed before the release.

[LaurenWags]

Verified passed with

Brave | 0.58.14 Chromium: 71.0.3578.98 (Official Build) (64-bit)
-- | --
Revision | 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS | Mac OS X

• Verified STR in description and test plan in https://github.com/brave/brave-core/pull/1075
  
  

Verification passed on

Brave | 0.58.14 Chromium: 71.0.3578.98 (Official Build) (64-bit)
-- | --
Revision | 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS | Windows 7

• Used STR from OP and test plan in https://github.com/brave/brave-core/pull/1075

Verification passed on

Brave | 0.58.15 Chromium: 71.0.3578.98 (Official Build) (64-bit)
-- | --
Revision | 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS | Linux