Brave-browser: Show full url like in Chrome

[ghost]

Test plan

1. Visit https://github.com/brave/brave-browser/issues/2192
2. The full URL (https://github.com/brave/brave-browser/issues/2192) should show in the URL bar

Description

Everytime I click on the URL, I have to click another time so it shows the full URL with https://.
This is so annoying! Chrome removed it few months ago, and Brave should as well.

[fmarier]

This corresponds to the "Omnibox UI Hide Steady-State URL Scheme" feature flag in chrome://flags. Disabling it will always show the full URL.

[cndouglas]

Thanks @fmarier! Disabling #omnibox-ui-hide-steady-state-url-scheme in brave://flags does show the https protocol part of the URL.

[LlamaFarma]

Is it just me, but this doesn't work for me fully.

For instance, if I go to www.google.com, it shows in the address bar as https://google.com.
If I click twice in the address bar it changes to the 'real' URL and shows https://www.google.com.
When I click away, the www goes.

I find this really annoying - I want to know the exact URL I'm on. Is there any way to fix it?

[cndouglas]

@LlamaFarma You also need to disable the setting #omnibox-ui-hide-steady-state-url-trivial-subdomains
Go to brave://flags#omnibox-ui-hide-steady-state-url-trivial-subdomains and change it to Disabled:

[LlamaFarma]

Thanks - that worked @Liunkae .
So, to summarise - if you want it to work the same way as Chrome, you need to disable both these settings...

omnibox-ui-hide-steady-state-url-scheme

omnibox-ui-hide-steady-state-url-trivial-subdomains

[Madis0]

Hiding the protocol is fine - the lock/warning icon displays the status more accurately anyway (mixed content and whatnot).

However, hiding the www. is what received the huge backlash for a good reason - it is simply inaccurate. See also: https://bugs.chromium.org/p/chromium/issues/detail?id=883038

[drauch]

Yep, please set "#omnibox-ui-hide-steady-state-url-trivial-subdomains" to Disabled by default! :+1:

[rebron]

Looks like this was addressed with https://github.com/brave/brave-browser/issues/4283
cc: @jumde

We're showing full url by default in nightly and we'd be reverting from what we're doing in current release build. cc: @toml

[bsclifton]

Thanks for confirming, @rebron - this is indeed closed. I'll move it to the 0.68.x milestone 😄

[btlechowski]

Verification passed on

Brave | 0.68.119 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
-- | --
Revision | 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS | Ubuntu 18.04 LTS

Verified steps from the description

Verification passed on

Brave | 0.68.129 Chromium: 76.0.3809.100 (Official Build) (64-bit)
-- | --
Revision | ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS | Windows 10 OS Version 1803 (Build 17134.523)

• Verified the STR mentioned in the description

Verified passed with

Brave | 0.68.131 Chromium: 76.0.3809.100 (Official Build) (64-bit)
-- | --
Revision | ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS | Mac OS X

• Verified STR from description