Brave-browser: Block Scripts shield sometimes doesn't work

[cndouglas]

Description

Edit: See my comment below.

Toggling on the Block Scripts shield does not disable JavaScript. This happens even after reloading the page several times after toggling the switch.

Steps to Reproduce

1. Open a new window and navigate to https://enable-javascript.com/
2. Click the Brave Shields button and toggle on Block Scripts.

Actual result:

Despite Block Scripts being enabled, JavaScript is still enabled.

The website text shows "Javascript is enabled in your web browser."

Expected result:

JavaScript should be disabled.

The website text should show "Javascript is disabled in your web browser", like Safari does when JavaScript is disabled:

Reproduces how often:

Sometimes.

Brave version (brave://version info)

Brave | 0.57.2 Chromium: 70.0.3538.67 (Official Build) dev(64-bit)
Revision | 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS | Mac OS X

Reproducible on current release:

• Does it reproduce on brave-browser dev/beta builds? Yes.

Website problems only:

• Does the issue resolve itself when disabling Brave Shields? No.
• Is the issue reproducible on the latest version of Chrome? No.

Additional Information

[srirambv]

Can't reproduce this on Windows

This is on Beta (0.56.6)

This is on dev (0.57.2)

[cndouglas]

Weird. After clearing cookies, caches, and content settings, this no longer reproduces for me.

[srirambv]

I just tried without having to clear cache and it worked. may be @kjozwiak could try and check on mac once.

[cndouglas]

I think the content/shield settings got in an inconsistent state (maybe because of an upgrade?). Perhaps clearing the content settings fixed it. I'll definitely keep an eye out for this problem to see if it happens again.

[srirambv]

@Liunkae that would be awesome. If you can check this during the next upgrade would be really helpful to see if the content settings getting messed up

[onmyouji]

I think the content/shield settings got in an inconsistent state (maybe because of an upgrade?). Perhaps clearing the content settings fixed it. I'll definitely keep an eye out for this problem to see if it happens again.

I had the same problem on Brave 0.55.20 / Windows 10
You're right, clearing the Content settings fixed it, just tested it myself.

[onmyouji]

The problem happens again after the latest update to 0.55.22

[srirambv]

Could be related to https://github.com/brave/brave-browser/issues/1991

[cndouglas]

Happened to me again, and I don't think there was an update involved this time (I'm on 0.57.4, the latest dev version). After clearing content settings and restarting the browser, the problem was resolved.

[onmyouji]

@Liunkae
Did you toggle your shield off/on? I'm able to reproduce the problem by doing that (issue 1991).

[kjozwiak]

@onmyouji can you still reproduce the issue on 0.56.12 which was just pushed? If you can still reproduce, can you provide some steps that you're using?

[cndouglas]

@onmyouji I don't think so, but I'm not sure. Could be the problem in #1991 because a new dev build has not been released yet with the fix.

[onmyouji]

@kjozwiak
Just updated to 0.56.12, I think the problem has been fixed now. Scripts are still being blocked after disabling/enabling.

[cezaraugusto]

I guess this has been solved, this is the result I have:

[tomlowenthal]

@kjozwiak Can we get a QA test on this, and either close if it's resolved or get STR if not?

[kjozwiak]

@tomlowenthal once things start cooling off with 0.57.x, @brave/legacy_qa will take a look and see if we can reproduce and provide STR 👍

[cndouglas]

I have not experienced this in several months, so I assume it's no longer a problem. Closing.