Brave-browser: Implement PrivacyPass

[riastradh-brave]

https://github.com/privacypass/challenge-bypass-extension

One of several avenues to pursue to reduce captcha fatigue on users, particularly Tor users.

Old issue: https://github.com/brave/browser-laptop/issues/13395

[riastradh-brave]

Cloudflare confirms this is on their roadmap to continue supporting, so this should continue to help with the Cloudflare captcha.

[riastradh-brave]

This is more or less blocked on https://github.com/brave/brave-browser/issues/2307 (along with the other issues labelled feature/tor/guest-semantics), because as private windows with Tor are implemented, extensions are blocked from being used altogether in them -- which is largely the right choice for security and anonymity, but in this case the upstream PrivacyPass is implemented as an extension.

[durch]

@riastradh-brave we're at a crossroads here with regard to implementation, initial idea was to implement privacypass extension as a native extension, so wrap it and expose relevant APIs. There are however concerns around maintainability of such a solution, as it might become a hassle keeping up with upstream updates. So we're back to evaluating pros and cons of both solutions. It seems that a bigger win would be to just do #2307. Then proceed with deciding if some special handling of extensions is required. Might be best to have them off by default and let users flip those switches and acknowledge the risks.

[tomlowenthal]

Just to clarify the requirements/approach here.

1. We're integrating Privacy Pass because it's really quite very useful in Tor.
2. We're probably just incorporating the existing extension, kinda the way we do for Webtorrent et al.
3. The functionality has to be available in Tor windows, and having it available in other windows would be great too.
4. We're going to need an off switch for it in settings: probably in the same place as other extensions.
5. We _might_ want to change the UI a little to be Brave-er. TBD.

[rulatir]

Can someone explain why Tor Browser SimplyHas™ this feature and why we can't have the same easily?

[alexander-chan]

Hi - just wanted to see if there is any updates for this. It's been over a year! :-)

[rulatir]

This isn't happening ever, right?

[tomlowenthal]

If there were updates, they'd be in this issue.

[ameyagokhale]

The issue was raised on Oct 18, 2018
Please increase the priority

[diracdeltas]

I'm happy to look at this. would it be sufficient to just integrate the Privacy Pass Chrome extension into brave tor profiles by default? https://github.com/privacypass/challenge-bypass-extension

[diracdeltas]

looks like the chrome privacy pass extension was taken down: https://chrome.google.com/webstore/detail/privacy-pass/ajhmfdgkijocedmfjonnpjfojldioehi

does anyone currently use it? does it still work?