Brave-browser: Enable Crash reporting by default for Dev and Nightly (0.63 and later)

Created on 16 Oct 2018  ·  10Comments  ·  Source: brave/brave-browser

Test plan

  1. Download and install Brave (Dev or Nightly channel, which has this fix)
  2. Fresh profile
  3. Go to brave://settings/
  4. Verify Automatically send crash reports to Brave is enabled

Description

Crash reporting should be enabled by default on Dev and Nightly so that we can get reports on whats causing the crashes. This should also be informed to the user on the welcome page probably on the first page as a note or as an option at the end. Preferably on the first view of the welcome page as some users might just click skip welcome tour and might not see it if its at the end.

cc: @bbondy @rebron @kjozwiak @bsclifton

QA Pass-Linux QA Pass-Win64 QA Pass-macOS QTest-Plan-Specified QYes featursettings prioritP2 release-noteexclude

Most helpful comment

@simonhong FYI - I just added a test plan (in case you wanted to verify it) 😄

All 10 comments

First run flow is a great place to put the notification. It could also go on the download page next to the download button.

Text is now live on the download pages for dev and beta, which ✅ the privacy review. We should be fine to actually turn this on now.

Prompt for release builds is in brave/brave-browser#1841.

screen shot 2018-10-25 at 2 59 12 pm

screen shot 2018-10-25 at 2 59 42 pm

@tomlowenthal should we mention but you can turn this off if you’d like. in the dev download page as well? You can still technically turn it off in dev. It might scare some users from using the dev channel? I'm not sure, might not be an issue. Just wanted to see what you thought 👍

I added it to the beta channel but not dev for two reasons. Number one, honestly was length — the dev text is already quite long. Number two was that I fully expect people using dev to go into their settings immediately after install and touch every button, switch, and knob. I very much doubt that anyone's going to compare the two pages and reach the conclusion that crash reporting can't be disabled on dev. And if folks are scared away from dev for that reason, I suspect they'd be happier on beta anyway. 🤷🏻‍♂️

Total number of users for dev and for beta are running the same right now.

I think we'll want to run some marketing efforts to get Beta 10x the size as dev at some point.

Per https://github.com/brave/brave-browser/issues/3729 - I verified this was never actually enabled
cc: @tomlowenthal

@simonhong FYI - I just added a test plan (in case you wanted to verify it) 😄

Verification passed on

Brave | 0.63.14 Chromium: 73.0.3683.75 (Official Build) dev (64-bit)
-- | --
Revision | 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS | Windows 10 OS Build 17134.523

image

Verification passed on

Brave | 0.63.15 Chromium: 73.0.3683.75 (Official Build) dev (64-bit)
-- | --
Revision | 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS | Linux mint

image

Verified passed with

Brave | 0.63.21 Chromium: 73.0.3683.75 (Official Build) dev(64-bit)
-- | --
Revision | 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS | Mac OS X

Brave | 0.64.8 Chromium: 73.0.3683.75 (Official Build) nightly(64-bit)
-- | --
Revision | 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS | Mac OS X

Was this page helpful?
0 / 5 - 0 ratings