Brave-browser: Regional Adblock doesn't work on Linux, follow up for #41

[srirambv]

Description

Regional Adblock doesn't work on Linux, follow up for #41

Steps to Reproduce

1. Clean install 0.55.5 on Linux
2. Set browser language to non English
3. Open chrome://adblock, regional adblock shows as disabled

Actual result:

On Linux having multiple languages, doesn't show option to Display Brave in this language

https://youtu.be/uXC0m_n3pOQ

Expected result:

Should set non English language as default and regional adblock should be enabled

Reproduces how often:

Easy

Brave version (chrome://version info)

Brave | 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
-- | --
Revision | 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS | Linux

Reproducible on current release:

No

Website problems only:

• Does the issue resolve itself when disabling Brave Shields?
• Is the issue reproducible on the latest version of Chrome?

Additional Information

Found while verifying #41
cc: @emerick @bbondy

[emerick]

@srirambv It seems that on Linux, this is controlled via the LANGUAGE environment variable (see https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/D6Eoeh0G9Y4 for the gory details).

When launching on Linux like this, I saw the expected settings in chrome://adblock:

LANGUAGE=fr_FR ./brave

[LaurenWags]

Verified steps from Description reproduce on macOS. However, if I set my system language/region to French/France:

and close/relaunch Brave, I see that Regional Adblock is enabled:

[kjozwiak]

@LaurenWags I think that's expected as @emerick mentioned that macOS and Linux relies on system level settings in https://github.com/brave/brave-browser/issues/41#issuecomment-426073347 which I assume would require the browser to be restarted for the settings to take affect.

@bbondy does that sound correct? Seems like it's only affecting Linux in any case as @LaurenWags's screenshot shows that Regional Ad Block: Enabled after a browser restart.

[bbondy]

I think that's correct, were you expecting something different to happen @LaurenWags ?

[LaurenWags]

@bbondy nope, I'm good - @emerick responded with https://github.com/brave/brave-browser/issues/41#issuecomment-426073347. Wanted to be sure I documented what I saw for historical purposes.

[srirambv]

I think this issue is easily solvable on Linux as well. Here's what i did

1. Add language packs from system settings
2. Change Language from settings and restart
3. Launch Brave and load adblock page, shows regional ad block enabled
   

[srirambv]

Verification Passed on

Brave | 0.55.17 Chromium: 70.0.3538.67 (Official Build) (64-bit)
-- | --
Revision | 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS | Linux