Brave-browser: Allow users to disable autocomplete

[bsclifton]

Test plan

See https://github.com/brave/brave-core/pull/4033

Description

Carried over from https://github.com/brave/browser-laptop/issues/3631

Some users would like a discrete setting to disable autocomplete for the omnibox. I don't believe this is offered by Chromium/Chrome (you can only disable predictive services)

[alego500]

Leaving comment to show interest in this feature as well.

[Brave-Matt]

+1 from Community and definitely a +1 from myself:
https://community.brave.com/t/how-do-i-turn-off-url-auto-complete/62316

[edanyal]

Please!

[Brave-Matt]

+1 from Reddit, multiple users
https://www.reddit.com/r/brave_browser/comments/b4jn8t/autocomplete_delete/epo0wd1?utm_source=share&utm_medium=web2x

[crocket]

auto-completion is a huge distraction. So, I turned it off in vivaldi web browser.
It's as distracting as smartphone notifications which I disabled except for the most important things.
Disabling auto-completion is good for maintaining focus.

[UsedToCould]

so are you guys gonna do something about this? you've been ignoring us for over a year.

[mjlp224]

Please make disabling autocomplete an option. It would be a good feature since many people save login credentials whose pages could be easily navigated to through autocomplete & then have their private information accessed.

[simonhong]

@mjlp224 Working on this for desktop :)

[mjlp224]

Awesome thanks Simon good to see someone on it I've been following the topic for a while. How about mobile?

[simonhong]

@rebron maybe disabling autocomplete on Mobile is another issue with this?

[rebron]

@anthonypkeane for thoughts on disabling autocomplete suggestions via a mobile setting? We're doing this for desktop.

Also @simonhong related issue https://github.com/brave/brave-browser/issues/5934 likely I can just dupe that issue to this one.

[rebron]

Example of this setting in Firefox, we'll want to just disable autocomplete and not go this granularly with bookmarks, history, open tabs.

[bsclifton]

Updated labels and added milestone/test plan after https://github.com/brave/brave-core/pull/4033 was merged 😄

[btlechowski]

Verification passed on

Brave | 1.3.81 Chromium: 79.0.3945.88 (Official Build) beta (64-bit)
-- | --
Revision | c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS | Ubuntu 18.04 LTS

Verified test plan from https://github.com/brave/brave-core/pull/4033.
Verified that autocomplete can be re-enabled.

Verification passed on

Brave | 1.3.87 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
-- | --
Revision | 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

• Verified the test plan from https://github.com/brave/brave-core/pull/4033
  Autocomplete option by default:
  
  

Disable Autocomplete option:

Verification PASSED on macOS 10.15.2 x64 using the following build:

Brave | 1.3.91 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
-- | --
Revision | 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS | macOS Version 10.15.2 (Build 19C57)

• ensured that Show autocomplete in address bar is being displayed under chrome://settings/appearance
• ensured that Show autocomplete in address bar is enabled by default
• ensured that disabling Show autocomplete in address bar doesn't show History, Bookmarks and current Opened Tabs in the omnibox when searching/typing