Brave-browser: Shields sometimes shows disabled on a tab even when its enabled

[srirambv]

Description

Shields sometimes shows disabled on a tab even when its enabled

Steps to Reproduce

1. Build from 2ae4e74b14ee322ec8d417dcff53e8cbc1dd08ed
2. Launch browser and switch to an inactive tab
3. Page loads, shields shows disabled icon but badge is shown
4. Click shields, shows enabled but icon looks disabled (see screenshot)

Actual result:

Expected result:

Should not show disabled icon when shields is enabled for a site

Reproduces how often:

100% on 2ae4e74b14ee322ec8d417dcff53e8cbc1dd08ed

Brave version (about:brave info)

2ae4e74b14ee322ec8d417dcff53e8cbc1dd08ed

Reproducible on current release:

Website problems only:

• Does the issue resolve itself when disabling Brave Shields?
• Is the issue reproducible on the latest version of Chrome?

Additional Information

cc: @cezaraugusto @bbondy

[bbondy]

I've noticed this happen too

[srirambv]

I can reproduce this issue on all tabs which are inactive upon browser launch. Here's the correct steps

1. Open 4 tabs and visit a different site on each of them
2. Keep tab 1 active and close and relaunch browser
3. Switch to inactive tab 2 and let the page load
4. Shields shows active badge but shields icon itself looks disabled but is clickable
5. Switch to tab 1 and switch back to tab 2, shields shows correct enabled icon

[cezaraugusto]

seems like a lifecycle issue I'll be on it next week as soon I finish sync ui

[srirambv]

This behaviour is changed on the latest build. After relaunch, shields looks disabled like before but clicking on it doesn't bring the shields menu. Changing tab focus enables the shields button again.

[cndouglas]

STR:

1. Open a new window and navigate to any website with a link.
2. Right click any link and click Open Link in New Tab.
3. Wait until the page has finished loading.
4. Switch to the new tab. Now the shields button is disabled.

[GeetaSarvadnya]

Verification PASSED on

Brave | 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
-- | --
Revision | 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS | Windows

Verification Passed on

Brave | 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
-- | --
Revision | 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS | Linux

Verified passed with

Brave | 0.55.10 Chromium: 70.0.3538.22 (Official Build) beta(64-bit)
-- | --
Revision | ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS | Mac OS X

• encountered similar issue while testing this, logged https://github.com/brave/brave-browser/issues/1392 for it