Brave-browser: Opening PDF in a tab shows chrome://extension URL and PDF extension favicon

Created on 17 Jun 2018  路  5Comments  路  Source: brave/brave-browser

Description


Opening PDF in a tab shows chrome://extension URL and PDF extension favicon

Steps to Reproduce

  1. Load any PDF in a new tab
  2. URL prefixes chrome-extension://oemmndcbldboiebfnladdacbdfmadadm/ to URL
  3. Tab shows PDF extension favicon instead of the site favicon

## Actual result:
image

Expected result:

Should not show the extension prefix and should load the website favicon. Only show extension icon if site doesn't have favicon set

Reproduces how often:

Brave version (about:brave info)


Install build

closeinvalid

Most helpful comment

Came here to report this; since there's already an open issue, I'll just add a comment to it. It looks like this is being worked on, so hopefully this will soon be moot, but I just want to respond to @bbondy's "it's OK" comment.

As an academic, I spend a lot of time reading PDF documents. It's not uncommon for me to go to a Web site (say a professor's publication list) and open up a bunch of documents in new tabs, and start reading. Eventually, I might get to one that's really interesting and I want to share with others. I can't just copy the URL and send it to someone else; either I have to manually edit it or they have to. Many people I know lack the facility to do this on either the sending or receiving side.

Since this is not the behavior in other browsers, there's no reason people would "just know" how to do such things. Especially since, to most users, the prefix (chrome-extension://oemmndcbldboiebfnladdacbdfmadadm/) looks like gibberish, and hence intimidating. Worse, in a context where the URL is presented through just a truncated prefix (e.g., a tweet), they wouldn't even _see_ the suffix where the "real" URL resides.

In short, I think this is pretty user-unfriendly, and as Brave starts getting more non-expert users, this is bound to cause confusion and consternation.

Thanks for working on fixing this.

All 5 comments

I think this is actually OK for now, so moving to backlog. Valid though.

Came here to report this; since there's already an open issue, I'll just add a comment to it. It looks like this is being worked on, so hopefully this will soon be moot, but I just want to respond to @bbondy's "it's OK" comment.

As an academic, I spend a lot of time reading PDF documents. It's not uncommon for me to go to a Web site (say a professor's publication list) and open up a bunch of documents in new tabs, and start reading. Eventually, I might get to one that's really interesting and I want to share with others. I can't just copy the URL and send it to someone else; either I have to manually edit it or they have to. Many people I know lack the facility to do this on either the sending or receiving side.

Since this is not the behavior in other browsers, there's no reason people would "just know" how to do such things. Especially since, to most users, the prefix (chrome-extension://oemmndcbldboiebfnladdacbdfmadadm/) looks like gibberish, and hence intimidating. Worse, in a context where the URL is presented through just a truncated prefix (e.g., a tweet), they wouldn't even _see_ the suffix where the "real" URL resides.

In short, I think this is pretty user-unfriendly, and as Brave starts getting more non-expert users, this is bound to cause confusion and consternation.

Thanks for working on fixing this.

This problem also hides the site info popup, which makes it harder to find the HTTPS certificate, cookies, and site settings.

Normal:

PDF:
image

I think we can close this in favor of #3846.

yep

Was this page helpful?
0 / 5 - 0 ratings

Related issues

AlexeyBarabash picture AlexeyBarabash  路  3Comments

fmarier picture fmarier  路  3Comments

Sondro picture Sondro  路  3Comments

lansana picture lansana  路  3Comments

qingxiang-jia picture qingxiang-jia  路  3Comments