I'd like to update the syntax to that of es6, thoughts?
robertleeplummerjr
All 17 comments
Seems legit. Maybe having an own branch for es6 is a good thing? So tagging different branches is made easier an makes the codebase compatible for older interpreter and users can choose a compatible version as they need.
MrIsaacs
on 28 May 2016
If we were to do it, I'd first create a new branch, then I'd like to ensure we use something like babel to compile it for compatibility. I'd also like to make part of the build process create a browser specific file, so that rather than doing it manually, it is built in. All of which wouldn't be too complicated.
robertleeplummerjr
on 28 May 2016
Once all that clears, then we could merge it into master, and continue on our merry way.
robertleeplummerjr
on 28 May 2016
It is here, huzzah!
robertleeplummerjr
on 5 Jul 2016
There's a tool caled lebab by @mohebifar which would be probably useful to convert it automagically and then edit the things that still have to be edited manually (if any). :grin:
IonicaBizau
on 26 Aug 2016
very cool!
robertleeplummerjr
on 26 Aug 2016
What would be our strategy for es5/legacy compatibility?
robertleeplummerjr
on 26 Aug 2016
Why not transpile it to es5 with babel as a prepublish step? That seems to be the normal route for modules written in es6+.
Macil
on 26 Aug 2016
I like it!
robertleeplummerjr
on 27 Aug 2016
@IonicaBizau I mostly manually translated it already.
robertleeplummerjr
on 27 Aug 2016
Ready and waiting here: https://github.com/harthur-org/brain.js/pull/28
robertleeplummerjr
on 7 Sep 2016
As soon as this is merged, auto builds are next, then a pr for the recurrent neural network stuff. Just fyi.
robertleeplummerjr
on 7 Sep 2016
Merged!
robertleeplummerjr
on 7 Sep 2016
For publishing I use babel-it which babelifies the files in place when npm publishing.
IonicaBizau
on 7 Sep 2016
Would you be up for taking a look at master, and seeing if you can apply your knowledge there?
robertleeplummerjr
on 7 Sep 2016
@robertleeplummerjr Well, pretty much npm i -g babel-it and instead of doing npm publish you do babel-it. 馃榿
IonicaBizau
on 7 Sep 2016
rnn, lstm, and gru working 100%, with some simple unit tests and travic-ci build: https://github.com/harthur-org/brain.js/pull/29
robertleeplummerjr
on 11 Sep 2016
Related issues
timendez
路
3Comments
lucaspojo
路
5Comments
VEXLife
路
4Comments
nezzard
路
5Comments
shopsoy
路
3Comments
Most helpful comment
Why not transpile it to es5 with babel as a prepublish step? That seems to be the normal route for modules written in es6+.