Brackets: Linux: Window doesn't close/quit on first click

[jasonsanjose]

On Ubuntu, when attempting to close the Brackets window via the X button, it takes 2 attempts before the window actually closes.

[timburgess]

I have done some investigation into this. It appears that earlier versions of the linux CEF3 didn't emit a GTK delete event - this has now been patched:
https://code.google.com/p/chromiumembedded/issues/attachmentText?id=780&aid=7800000000&name=gtk_delete_event.diff&token=-r_yEWKd9SaWYQGP9URC7I91jxI%3A1374642422808

The present code has a workaround which now that we are using patched CEF3 versions results in multiple clicks required.

[bradberger]

Also having a similar problem with newly installed Sprint 32 (sprint 32 experimental build 0.32.0-9791 (On branch master,master e49a849fb) installed via deb package on Xubuntu 13.04. In fact, it's not closing at all. As a result, need to kill both brackets and brackets-node processes.

This didn't occur with Sprint 31 on the same system, so perhaps something's changed recently. Thanks!

[redmunds]

@dixonge The core team is short on native Linux skills. Would you like to try to fix this one?

[fakam]

Same thing on Ubuntu 13.10 / Mint 16 64bit

[jdittrich]

same here 12.04, Brackets 36

Are there any additional infos on that to ease the assessment of the problem for people who want to try to fix it? If I understand @timburgess correctly, the problem is caused by code in Brackets which was a workaround for a now-fixed bug in CEF?

[peterflynn]

Looks like someone should try uncommenting the disabled code in the Linux impl of CloseWindow(): https://github.com/adobe/brackets-shell/blob/master/appshell/appshell_extensions_gtk.cpp#L479

UPDATE: the "disabled code" referred to above now seems to be on a different line:
https://github.com/adobe/brackets-shell/blob/master/appshell/appshell_extensions_gtk.cpp#L531

Anyone want to give that a try and send a PR if it works?

[peterflynn]

Note: Dupe #5714 (or #7794) has some steps where this could cause data loss. Marking 'needs review' to consider whether the core team should take cycles to work on this.

[dangoor]

Assigned to @redmunds to follow up with community member who might be interested in this.

[sryze]

I have this problem too, Brackets 0.44 on Ubuntu 14.04

[peterflynn]

@redmunds Is someone working on this? It looks like you added 'fix in progress' recently but also cleared the assignee...

[redmunds]

@peterflynn The pull request is https://github.com/adobe/brackets-shell/pull/458. This was assigned to me, but I have not been involved with it, so I removed myself.

[MrSkwiggs]

This bug still exists in Brackets Release 1.2 experimental build 1.2.0-15697 (release 8f82e2a97)
and Release 1.3 experimental build 1.3.0-012 (release 2fbd9d392) .
Also, when reopening Brackets, it reverts to a smaller window size even if it was fullscreen before exiting...

[rthouvenin]

Anything blocking the review / merge of the PR? The fix seems to work according to @jasonsanjose

[robinpecha]

Ubuntu 14.04 - Brackets 1.6 bug still exists.
Does someone have clear tip how to patch it right now?

[jextrevor]

Still having this issue, Ubuntu 16.04 - Brackets 1.7. I concur with @Mr-Skwiggs - the window does revert to a smaller size after reopening, even if it was fullscreen.

[zaggino]

@jextrevor try brackets-electron, https://github.com/zaggino/brackets-electron/releases current version matches latest brackets and works much better on linux (minus live preview functionality)

[axedre]

Looks neat, will wait for some good soul to include it in AUR since I use arch linux...

[zaggino]

@axedre you should be able to install AppImage on arch linux as far as I know. More info on http://appimage.org/

[cybbro]

Still having this issue on Brackets 1.10 on Ubuntu GNOME 17.04 64bit, I always have to press close two times to exit the program.

[saurabh95]

Fixed By: https://github.com/adobe/brackets-shell/pull/619