Bpftrace: Help reviewing remaining PRs for 0.9.1

[mmarchini]

We had a lot of changes since 0.9.0 came out, and all issues we have on 0.9.1 milestone have a Pull Request open. I would like to merge these soon so we can release 0.9.1 and start focusing on 0.9.2.

These are the PRs I have in mind so far:

• [x] [need review] semantic,codegen: allow optional positional params
• [x] [changes requested] Fully implement ++ and -- #486
• [x] [need review] codegen: fix ntop usage with maps and printf #762
• [x] [need review] clang_parser: workaround for asm goto in Kernel 5+ headers #732
• [x] [need review] [tests] add missing tests to codegen.cpp #574
• [x] [need review] Fix attaching to USDT probes with semaphore and USDT runtime tests #691
• [x] [need review] Parse negative integer literals correctly #623
• [x] [need review] bison: introduce compound assignment operators #448
• [x] [need review] Fix error handling of invalid 'args' utilization #726
• [x] [need review] semantic_analyzer: check if positional parameters was given #723
• [x] [need review] codegen: don't rely on LLVM unrolling our loops #722
• [x] [need review] tests: fix and improve runtime tests #690

If folks could help reviewing those PRs, that would be awesome.

Also, if there are other PRs folks believe should go in our next release, please comment here so we can decide if it should be included or not. I would like to avoid merging big or impactful changes before we release 0.9.1 (especially https://github.com/iovisor/bpftrace/pull/535, https://github.com/iovisor/bpftrace/pull/667 and https://github.com/iovisor/bpftrace/pull/711) since it would be nice to have those changes in master for a few weeks before they make into a release.

[danobi]

I volunteer #623 to be included :)

[danobi]

I can help review some stuff.

[mmarchini]

I volunteer #623 to be included :)

Makes sense, and doesn't look like something risky to have in the next release. I'll add to the list :)

[mmarchini]

Should we include https://github.com/iovisor/bpftrace/pull/714? On one hand it fixes two issues, on the other hand I'm worried of having it in a release without having it on master for some time first.

[danobi]

I think it should bake in master a bit. I don't think it's a critical bug.

[mmarchini]

I'll add #732 since several users are facing this issue.

[mmarchini]

Also adding https://github.com/iovisor/bpftrace/pull/762 because it fixes a critical issue with ntop.

[danobi]

Should we cut release branches instead of doing version-freeze tags on PRs?

[mmarchini]

Yes, that would be better.

[mmarchini]

I'm writing the changelog for 0.9.1 now. I think maybe https://github.com/iovisor/bpftrace/pull/742 should be included as well, otherwise we'll introduce a breaking change in this version (disallow optional positional parameters) just to revert to the old behavior in the next version.

[ajor]

All PRs merged!

[mmarchini]

v0.9.1 was released today, so I'll close this issue.

Thank you for everyone who helped with reviews and pull requests!