Botman: Update react/socket to a more recent version

Created on 13 Apr 2019  路  4Comments  路  Source: botman/botman

Description:

My discord drivers require the use of react/socket ^1.1 but botman requires 0.4.* I can't downgrade as the newer versions fix an bug. Botman should upgrade to a newer version of react/socket. Botman is 22 versions behind (3.4 years)

Steps To Reproduce:

{
  "name": "something/overtherainbow",
  "description": "a bug",
  "minimum-stability": "stable",
  "license": "proprietary",
  "require": {
    "botman/botman": "~2.0",
    "php": ">=7.1",
    "charlottedunois/yasmin": "^v0.6.0",
  },
}

composer install

yasmin requires react-buzz for async requests. Which requires react/socket ^1.1

Most helpful comment

I've been testing the unreleased code and it all works without any issues.

All 4 comments

I noticed you have already fixed this issue in #943 but have not made a release. Can we make this a release?

@mpociot

I've been testing the unreleased code and it all works without any issues.

My PPM driver requires latest react/socket as well and I don't want to make yet another fork just for this...

Sorry for the long waiting time. I just tagged 2.5.0

Was this page helpful?
0 / 5 - 0 ratings

Related issues

antonkomarev picture antonkomarev  路  5Comments

s4rrow picture s4rrow  路  5Comments

kubk picture kubk  路  4Comments

matejminar picture matejminar  路  5Comments

alvinmurimi picture alvinmurimi  路  4Comments