Botkit: [Facebook]Promisify APIs

[ouadie-lahdioui]

Hello 👋

Some Facebook APIs need to be Promisified in order to to support Promises in addition to callbacks.

Her's the list of APIs that not yet promisified

• [ ] attachment_upload_api
• [ ] nlp
• [ ] tags
• [ ] handover
• [ ] broadcast_api
• [ ] insights_api

And her's those already promisified :

• [x] messenger_profile_api
• [x] user_profile

Good luck!

[htaidirt]

I take it, @ouadie-lahdioui, if you don't mind.

[htaidirt]

@ouadie-lahdioui I've made the necessary changes. Should I also create the related specs? What's the agreement when it comes to testing?

[ouadie-lahdioui]

You need to make a new PR to the project.

[htaidirt]

Done 👍 https://github.com/howdyai/botkit/pull/1520

All the following methods have been promisified:

• [x] attachment_upload_api
• [x] nlp
• [x] tags
• [x] handover
• [x] broadcast_api
• [x] insights_api

[htaidirt]

Hi @ouadie-lahdioui,

I'm looking at the docs, and thinking about updating them with my recent changes. But I can't figure out where I should make these changes. Probably there is another repo?

Can you please point out where I can document the promise version of the edited methods?

Thanks

[ouadie-lahdioui]

Awesome!

Her's the new documentation repository.

[htaidirt]

Thanks @ouadie-lahdioui. I just created an Issue there to ask guidance on how better document both ways: callback and promise.

https://github.com/howdyai/botkit-docs/issues/22

[benbrown]

Great work, gentlemen. I'll review asap.