Botframework-solutions: Answering NO on skill switch prompt fails to restart skill

[Bots4life]

What project is affected?

Virtual Assistant and Skills

What language is this in?

Typescript

What happens?

When skill switch prompt is triggered and the user answers "No" it fails to invoke the skill.

What are the steps to reproduce this issue?

Go into a skill from the VA, type interrupt to switch to another skill and enter no to the skill switch prompt.

What were you expecting to happen?

The current skill to restart.

Can you share any logs, error output, etc.?

The error is: Error: Error invoking the skill id: "myfavoriteskill" at "https://**.azurewebsites.net/api/messages" (status is 500). ReferenceError: err is not defined at SkillDialog. (D:\home\site\wwwroot\nodemodules\botbuilder-dialogs\lib\skillDialog.js:160:23) at Generator.next () at fulfilled (D:\home\site\wwwroot\nodemodules\botbuilder-dialogs\lib\skillDialog.js:11:58) at process.tickCallback (internal/process/nexttick.js:68:7)

Any screenshots or additional context?

No

[Batta32]

Thanks @Bots4life for reporting this issue! Are you using the TypeScript samples or creating the bots using [email protected]?

As soon as we have any update, we will back to you here 😊.

[Bots4life]

Thanks for the reply @Batta32
We are using the TypeScript samples

[Bots4life]

Adding in a screenshot for context

[mrivera-ms]

@Batta32 could you please take a look at the customer's answer? Thank you.

[VictorGrycuk]

Hi @Bots4life & @mrivera-ms, sorry for the delay. We replicated the scenario but the error was not reproduced.

To help us understand and reproduce the issue, we have some questions:

1. Have you tried to test the Skill running on its own?
2. Which files have you modified when customizing the sample skill? How?
3. What version of BotBuilder SDK are you using in the VA & Skill? You can check this on your package-lock.json
4. Is the method repromptDialog of your skill called? This method is executed after the switchSkillDialog prompt
5. Does this issue also happens on the BotFramework Emulator?

Our environment:

• Virtual Assistant Sample
• Sample Skill x2
• MS Teams
• BotFramework Emulator

To test the scenario we followed these steps:

1. Connect both Skills to the Virtual Assistant
2. Add the Virtual Assistant to MS Teams
3. Call the first Skill
4. Call the second Skill in the middle of the conversation of the first Skill
5. Send "no" when asked to switch Skill
6. The first Skill dialog was reprompt as normal

We tested the scenario both in MS Teams and in BotFramework Emulator, in both cases we had the same result.

We will be attentive to your comments 🙂.

[Bots4life]

@Batta32 @VictorGrycuk @mrivera-ms
Thank you for the help and quick responses everyone, we found the issue was with a modification we made to the defaultActivityHandler. Inside of onEndOfConversationActivity() we added a sendEoCToParent() to help with an issue we were having with another customization. Removing this line allows the skill to be restarted properly.

Thanks again!