Botframework-solutions: Version 4.10.3 - Exception: System.MissingMethodException: 'Method not found: 'AdaptiveExpressions.EvaluateExpressionDelegate...

[dawwa]

Github issues should be used for bugs and feature requests. Use Stack Overflow for general "how-to" questions.

Version

4.10.3

Describe the bug

Throws System.MissingMethodException after upgrading build packages from 4.9.3 to 4.10.3 for Bot Framework Solutions Skill project.

at Microsoft.Bot.Builder.LanguageGeneration.Templates.InjectToExpressionFunction() in D:\a\1\s\libraries\Microsoft.Bot.Builder.LanguageGeneration\Templates.cs:line 366 at Microsoft.Bot.Builder.LanguageGeneration.Templates..ctor(IList``1 templates, IList``1 imports, IList``1 diagnostics, IList``1 references, String content, String id, ExpressionParser expressionParser, ImportResolverDelegate importResolver, IList``1 options) in D:\a\1\s\libraries\Microsoft.Bot.Builder.LanguageGeneration\Templates.cs:line 55 at Microsoft.Bot.Builder.LanguageGeneration.TemplatesParser.InnerParseText(String content, String id, ImportResolverDelegate importResolver, ExpressionParser expressionParser, Dictionary``2 cachedTemplates) in D:\a\1\s\libraries\Microsoft.Bot.Builder.LanguageGeneration\TemplatesParser.cs:line 130 at Microsoft.Bot.Builder.LanguageGeneration.MultiLanguageLG..ctor(Dictionary``2 filePerLocale, String defaultLanguage) in D:\a\1\s\libraries\Microsoft.Bot.Builder.LanguageGeneration\MultiLanguageLG.cs:line 35 at Microsoft.Bot.Solutions.Responses.LocaleTemplateManager..ctor(Dictionary``2 localeTemplateFiles, String fallbackLocale) in D:\a\1\s\sdk\csharp\libraries\microsoft.bot.solutions\Responses\LocaleTemplateManager.cs:line 30

To Reproduce

Steps to reproduce the behavior:

1. Go to https://microsoft.github.io/botframework-solutions/skills/tutorials/create-skill/csharp/1-intro and create a test skill project
2. Build and try to debug startup of the skill project, the startup should work fine at this moment
3. Modify the project to upgrade all the bot build packages from 4.9.3 to 4.10.3
4. Try startup again and expect the exception to show up.

Expected behavior

Startup properly without exceptions after upgrading to 4.10.3

[lauren-mills]

Did a review of this and this appears to be an issue with the MultiLanguageLG class which the LocaleTemplateManager implements, not with the Microsoft.Bot.Solutions lib.

[cleemullins]

@boydc2014 Can you look at this? It seems like a bug in the underlying LG library.

[boydc2014]

@boydc2014 Can you look at this? It seems like a bug in the underlying LG library.

Sure, looking soon. At at first galance, it's because we may move some helper functions as the refactor to split the gaint function table.

[Danieladu]

Sure, looking soon. At at first galance, it's because we may move some helper functions as the refactor to split the gaint function table.

I suspect this is also the reason. But I could not reproduce it on my side. So, @dawwa May you provide more details/or just check in the bug branch so we can anchor the issue quickly.

[Danieladu]

The root cause is skill library Microsoft.Bot.Solutions depends on But.builder 4.9.3, But customer update some outer packages into 4.10.3, which are not compatible with each other.
There are several suggestions:

1. Keep the outer project depends on 4.9.3 (If the features provided by this version covers all the requirements)
2. Update the Botbuilder SDK version in Microsoft.Bot.Solutions from 4.9.3 to 4.10.*

Any suggestions? @cleemullins @lauren-mills

[boydc2014]

So, @Danieladu's investigation shows this is due to a conflict caused by multiple versions of libraries are used. The fix, as suggestioned above is either keep everything in 4.9, or upgrading to 4.10 for all packages.

I will definitely suggest upgrading to 4.10 if possible @lauren-mills.

So closing this for now, cc @cleemullins.

[cleemullins]

Thanks @boydc2014 and @Danieladu.

@lauren-mills can we fix this ASAP?

[lauren-mills]

Confirmed with @dawwa that this is not a blocking issue at the moment. Since we'll need to solve this same problem for the R11 release we'll wait until its out to make the update and push the changes then.

@Batta32 - This should be solved with an update to the Microsoft.Bot.Solutions package to use the latest SDK version, but we'll wait for 4.11

[Batta32]

Thanks @lauren-mills, we will wait for 4.11 to update the packages to use the latest SDK version.

In addition to this, we have the PR #3632 which updates the C#/TypeScript solutions to 4.10.3 and we are currently working to update TypeScript to [email protected]

[stevengum]

Assigning to @Batta32 as it seems his team will be performing the version bump for 4.11.

[github-actions[bot]]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

[Batta32]

Hi @lauren-mills and @stevengum , we created the PR #3707 updating the C#/TypeScript solutions to SDK R11.

Also, we confirmed that this issue is fixed with that PR and can be closed as soon as the PR is merged and new packages are published.

[ObsidianDelta]

Just FYI ... Used Microsoft.Bot.Solutions v 1.0.1 ... but that does not have the up to date Microsoft.Bot.Builder.LanguageGeneration and Microsoft.Bot.Builder.TemplateMangager packages! So had to upgrade the nuget package for both of them to v 4.11.1 ... and we don't get the error anymore.

[bojingo]

@ObsidianDelta - thanks for that! I was updating a solution to 4.13.2 and encountered this issue as well. In my case I had to explicitly add package dependencies to the packages you mentioned to get past these errors. In my solution I was pulling those packages in implicitly

@Batta32 - it really doesn't seem appropriate to close this issue and call it fixed. Clearly the dependencies from the Microsoft.Bot.Solutions package are incorrect. Version 1.0.1 lists Microsoft.Bot.Builder.TemplateManager and LanguageGeneration >= 4.9.3 but obviously this is incorrect. Please fix your dependency declarations on this package so other customers don't get bit by the same error.