Botframework-solutions: [Botskills] wrap path with quotes

[xieofxie]

What project is affected?

Botskills

What language is this in?

Typescript

What happens?

Not all parameters are wrapped with quotes

Like here https://github.com/microsoft/botframework-solutions/blob/96db93b187d838e978d6502827bf8f92169ee28f/tools/botskills/src/functionality/connectSkill.ts#L124, https://github.com/microsoft/botframework-solutions/blob/96db93b187d838e978d6502827bf8f92169ee28f/tools/botskills/src/functionality/refreshSkill.ts#L96 etc.

What are the steps to reproduce this issue?

See this https://github.com/microsoft/botframework-skills/issues/279

What were you expecting to happen?

Can you share any logs, error output, etc.?

Any screenshots or additional context?

[Batta32]

Thanks @xieofxie for reporting this issue. We will be reviewing it and as soon as we have any update we will back to you 😊.

[Batta32]

Hi @xieofxie - sorry for the delay.

We successfully reproduced the mentioned scenario using a path with whitespaces on it. We will be analyzing the solution for the issue and back to you later 😊.

[Batta32]

Hi @xieofxie - we created the PR #3587 fixing this issue.

You can validate the changes following these steps:

1. Checkout to the branch southworks:feature/southworks/fix-path-botskills-error
2. Go to the botskills tool
3. Execute npm install to install the depedencies
4. Execute npm run build to compile the solution
5. Execute npm link to link the tool. If you have installed botskills, you should execute npm uninstall -g botskills to uninstall the tool.
6. Check that the values are wrapped between quotes using the botskills' commands

We will be attentive to your answer 😊!

[xieofxie]

Hi @Batta32, I would suggest we wrap values with quotes in runCommand function https://github.com/southworks/botframework-solutions/blob/646de1572e2ff3038c07cbc6d6dcdc4960a52db7/tools/botskills/src/functionality/connectSkill.ts#L154, https://github.com/southworks/botframework-solutions/blob/646de1572e2ff3038c07cbc6d6dcdc4960a52db7/tools/botskills/src/functionality/refreshSkill.ts#L22

Or we will lack the wrapping of executeDispatchAdd, refresh skill.
Thanks

[Batta32]

@xieofxie - we successfully wrapped the values with quotes in the bf luis:convert and bf luis:generate commands too. After these changes, we confirmed that if any argument's values contains whitespaces, the tool will correctly work. You can see the new changes in the PR #3587.

Also, we identified that if we wrap the values with quotes in the dispatch add and dispatch refresh commands, botskills fails, so we can't update the mentioned runCommand.

Finally, you can validate the changes following the mentioned repro steps.

[github-actions[bot]]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days