Botframework-sdk: Change onTeamsMemberAdded for Teams to use getMember()

Created on 21 Apr 2020  Â·  3Comments  Â·  Source: microsoft/botframework-sdk

The onTeamsMemberAdded event calls getMembers() to create a fully hydrated TeamsChannelAccount object. Now that Teams has released the get single member endpoint, we should update the SDK to use that instead.

As an example, here's the method in the C# repo that needs to be changed: https://github.com/microsoft/botbuilder-dotnet/blob/92242ea0826ea94e671d1b1a98c62fcd5042059a/libraries/Microsoft.Bot.Builder/Teams/TeamsActivityHandler.cs#L251

Tracking Status

Dotnet SDK (Tracked in Issue)

  • [x] PR
  • [x] Merged

Javascript SDK (Tracked in Issue)

  • [x] PR
  • [x] Merged

Python SDK (Tracked in Issue)

  • [x] PR
  • [x] Merged

Java SDK (Tracked in

  • [x] PR
  • [x] Merged

Most helpful comment

It needs to be said publicly: @EricDahlvang - a true Avatar
image

All 3 comments

We should add Java to this since the next preview will have Teams support.

It needs to be said publicly: @EricDahlvang - a true Avatar
image

My grandmother used to tell me stories about the old days, a time of peace when the Avatar kept balance between the Java Tribes, Python Kingdom, Lisp Nation, and COBOL Nomads. But that all changed when the Javascripters attacked.


From: Ashley Finafrock notifications@github.com
Sent: Thursday, April 30, 2020 8:18:08 PM
To: microsoft/botframework-sdk botframework-sdk@noreply.github.com
Cc: Subscribed subscribed@noreply.github.com
Subject: Re: [microsoft/botframework-sdk] Change onTeamsMemberAdded for Teams to use getMember() (#5810)

It needs to be said publicly: @EricDahlvanghttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FEricDahlvang&data=02%7C01%7CChris.Mullins%40microsoft.com%7C21fe5a67b0a94ed5019a08d7ed7e458e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637238998908240759&sdata=jLrv7X861RnuYuvhaxYZN7%2BhwlTz%2FsQ2vD41UCgkW2I%3D&reserved=0 - a true Avatar
[image]https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F35248895%2F80779155-9d729280-8b1f-11ea-9a83-02851f8d333e.png&data=02%7C01%7CChris.Mullins%40microsoft.com%7C21fe5a67b0a94ed5019a08d7ed7e458e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637238998908240759&sdata=2Jr%2BWKSsjY7R6FcrEESCGi2sJqXthjaF2xVbggJDCcQ%3D&reserved=0

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fbotframework-sdk%2Fissues%2F5810%23issuecomment-622228688&data=02%7C01%7CChris.Mullins%40microsoft.com%7C21fe5a67b0a94ed5019a08d7ed7e458e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637238998908250753&sdata=ArVpKrgLyP4PQX9han6TTgRejyFGy9ShqNDsUEhKK6Y%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAI4QCNGTLGP3NNTH4WDN6LRPI5PBANCNFSM4MM4AMUQ&data=02%7C01%7CChris.Mullins%40microsoft.com%7C21fe5a67b0a94ed5019a08d7ed7e458e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637238998908250753&sdata=B6fdlRoEymo19S1nGqMzOCykSS4zb12V4%2FQalQ5dFaw%3D&reserved=0.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

vaditya04 picture vaditya04  Â·  3Comments

Arimov picture Arimov  Â·  3Comments

hailiang-wang picture hailiang-wang  Â·  3Comments

kenyeung128 picture kenyeung128  Â·  3Comments

jschristophe picture jschristophe  Â·  3Comments