Botframework-sdk: Exception: invalid need: expected Wait, have Done

[xoposhiy]

I receive exception in emulator, when doing EchoBot with Bot Builder exactly as shown in documentation. (EchoDialog is copy pasted)

Message and stack-trace are not very informative. I can't understand what exactly is wrong in my code.

The same project works well if I do it without Bot Builder.

{
  "message": "An error has occurred.",
  "exceptionMessage": "invalid need: expected Wait, have Done",
  "exceptionType": "Microsoft.Bot.Builder.Internals.Fibers.InvalidNeedException",
  "stackTrace": "   в Microsoft.Bot.Builder.Internals.Fibers.Wait`1.ValidateNeed(Need need)\r\n   в Microsoft.Bot.Builder.Internals.Fibers.Wait`1.Microsoft.Bot.Builder.Internals.Fibers.IWait.Post[D](D item)\r\n   в Microsoft.Bot.Builder.Internals.Fibers.Extensions.Post[T](IFiber fiber, T item)\r\n   в Microsoft.Bot.Builder.Dialogs.Internals.DialogContext.<Microsoft-Bot-Builder-Dialogs-Internals-IUserToBot-SendAsync>d__20.MoveNext()\r\n--- Конец трассировка стека из предыдущего расположения, где возникло исключение ---\r\n   в System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n   в System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   в Microsoft.Bot.Builder.Dialogs.Conversation.<SendAsync>d__2.MoveNext()\r\n--- Конец трассировка стека из предыдущего расположения, где возникло исключение ---\r\n   в System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n   в System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   в System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()\r\n   в Bot.Controllers.MessagesController.<Post>d__0.MoveNext() в C:\\work\\TsyaBot\\Bot\\Controllers\\MessagesController.cs:строка 22\r\n--- Конец трассировка стека из предыдущего расположения, где возникло исключение ---\r\n   в System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n   в System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   в System.Threading.Tasks.TaskHelpersExtensions.<CastToObject>d__3`1.MoveNext()\r\n--- Конец трассировка стека из предыдущего расположения, где возникло исключение ---\r\n   в System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n   в System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   в System.Web.Http.Controllers.ApiControllerActionInvoker.<InvokeActionAsyncCore>d__0.MoveNext()\r\n--- Конец трассировка стека из предыдущего расположения, где возникло исключение ---\r\n   в System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n   в System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   в System.Web.Http.Controllers.ActionFilterResult.<ExecuteAsync>d__2.MoveNext()\r\n--- Конец трассировка стека из предыдущего расположения, где возникло исключение ---\r\n   в System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n   в System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   в System.Web.Http.Filters.AuthorizationFilterAttribute.<ExecuteAuthorizationFilterAsyncCore>d__2.MoveNext()\r\n--- Конец трассировка стека из предыдущего расположения, где возникло исключение ---\r\n   в System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n   в System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   в System.Web.Http.Dispatcher.HttpControllerDispatcher.<SendAsync>d__1.MoveNext()"
}

[willportnoy]

Try starting a new conversation by changing the conversation ID. You would see this exception if your code finished without calling something like context.Wait(MessageReceived). We'll work to improve the error message.

[Stevenic]

Please re-open this issue if you've tried Will's suggestion and are still seeing an exception.

[rodzillarr]

I believe the solution is to clear your user profile by sending the framework a /deleteprofile message.

Good luck!

-r

[jamesrlewis]

I had a similar issue and Will's solution worked, but I'm curious as to why this happens and how I can prevent the code from finishing before it calls context.Wait(MessageRecieved). Any ideas?

[willportnoy]

I recently added a commit https://github.com/Microsoft/BotBuilder/commit/fa07e71774fc3e8ed7e943f22f48b891e806f32a (with some tests) to translate this exception to something more intelligible.

If you want to ensure that context.Wait(MessageReceived) is always called within a method, you can use a finally block or implement a IDisposable struct scoped to a using-block.

But it's not always what you want to do, because you may have some other method you'd like to received the next message into, to model some sort of state machine.

If you're using the LuisDialog, you might consider deriving from it and overriding the MessageReceived to call the base implementation then call context.Wait(MessageReceived), but that presumes you don't have more complicated state you want to track.

[jamesrlewis]

okay. I opened another issue that's more specific to my problem than this thread. Thanks for your input

[niyatia]

@willportnoy I get this error when I call the bot from slack. It works in emulator after executing deleteprofile command but I am not able to get rid of this error when I call it from slack. How can I delete profile or clear state from previous conversation and start a new one?

_Update:_ I tried to make the same conversation with bot using different slack user and it worked for the first time. It gives the same error again with this new user when I tried to do it 2nd time. The issue here I think is that I have got some error with both the users performing some action that only worked first time. The conversation got into a hanged state right then. Is there a way I can clear the earlier context of the user-bot conversation and make it a fresh start every time bot is called by any user?

[willportnoy]

You need to add a space before /deleteprofile so that it's not interpreted by slack.

[willportnoy]

I'm going to close this issue for now, but feel free to open a new issue with further questions.

[willportnoy]

@enojo can you open a new top level issue for your LUIS question?

[nornes]

I have a similar issue with an error message saying:
Exception: invalid need: expected Wait, have Call
It occures in the return function after authbot has authenticated and I am trying to forward the message into the mail dialog. My code:
```
[Serializable]
public class AuthDialog : IDialog
{
public async Task StartAsync(IDialogContext context)
{
context.Wait(MessageReceivedAsync);
}
public async Task MessageReceivedAsync(IDialogContext context, IAwaitable item)
{
//original message if we need to resume
var message = await item;

        //try to get access token
        var token = await context.GetAccessToken("https://graph.microsoft.com/");
        if (string.IsNullOrEmpty(token))
        {
            //invoke the AuthBot to help get authenticated
            await context.Forward(new AzureAuthDialog("https://graph.microsoft.com/"), this.resumeAfterAuth, message, CancellationToken.None);
        }
        else
        {
            //token exists...forward to GraphDialog
            await context.Forward(new RootDialog(), null, message, CancellationToken.None);
        }
    }

    private async Task resumeAfterAuth(IDialogContext context, IAwaitable<string> result)
    {
        //post the response message and then go back into the MessageReceivedAsync flow
        var message = await result;
        await context.PostAsync(message);

        //now that token exists...forward to GraphDialog
        await context.Forward(new RootDialog(), null, message, CancellationToken.None);
        context.Wait(MessageReceivedAsync);
    }
}

}```

[JasonSowers]

@nornes Can you please open a new issue or post on stack overflow for this?

[poojashivach]

@nornes : can you let me know how you have resolved the above issue??

I am also using AuthBot package for authentication, and my bot flow is similar to yours.

When access token is not present after authentication I get the same error as you i.e. Exception: invalid need: expected Wait, have Call.

Thanks in advance!