Botbuilder-js: tslint doesn't lint botbuilder-js repo

Created on 23 Jan 2019  路  3Comments  路  Source: microsoft/botbuilder-js

Versions

4.2.0

Describe the bug

Running command npm run tslint (or more specifically tslint ./libraries/*/src/*.ts ./libraries/*/src/**/*.ts -t verbose) from botbuilder-js root

results in:
No valid rules have been specified for TypeScript files

Expected behavior

For linting rules to run

Screenshots

From travis:
image

[bug]

bug 4.4

Most helpful comment

We will re-enable the linter the day after 4.3 ships!

All 3 comments

To clarify on this, @Zerryth is going to _reenable_ tslint, because we've been checking code that hasn't been going through the linting process.

For her PR #704 that addressed some ongoing issues with QnAMaker, she will go back in another PR and lint that class after TSLint is back online.

We will re-enable the linter the day after 4.3 ships!

This will be replaced by #806 where I've re-enabled linting and switched over to using eslint.

Was this page helpful?
0 / 5 - 0 ratings