I'd like to help push forward with #27514 by implementing a mix-in for dark mode or light mode that can be used by users and throughout the Bootstrap source code. I will file a pull request with my improvements when I'm finished (if this sounds OK).
juniorRubyist
All 5 comments
If I can. I see that You are planning to add dark theme to bootstrap which is great.
But I also see that You are connecting dark theme with prefers-color-scheme.
I think it suppose to be independent. Some users might want to have dark theme while having light system theme. Or maybe dark theme would be tirggered during day and night?
piernik
on 31 Oct 2019
@piernik I'm simply just writing a mixin for Sass for the media query. If someone wanted to force the theme, they could write the theme as a class and @extend it in the @include dark-scheme {}.
juniorRubyist
on 31 Oct 2019
@juniorRubyist I'm not sure your suggestion. Can you create a PR or show demo on https://www.sassmeister.com/ for clarity?
ysds
on 1 Dec 2019
@ysds #29552
juniorRubyist
on 1 Dec 2019
@juniorRubyist thanks, I missed it
ysds
on 1 Dec 2019
Related issues
IamManchanda
路
3Comments
knownasilya
路
3Comments
matsava
路
3Comments
devdelimited
路
3Comments
alvarotrigo
路
3Comments