Bootstrap: Tweak /utilities/borders/#border-radius

[XhmikosR]

https://twbs-bootstrap.netlify.com/docs/4.3/utilities/borders/#border-radius

This doesn't look so good, and also on mobile the images don't have any vertical margins. Could be improved IMO.

[SeasonLeee]

Hi,😊 I also discover this issue in the live v4.3 doc, when the viewpoint is less than 1132px

And I think we can add margin: .25rem to fix this issue just like it's used on the border example above

although I know that this class name bd-placeholder-img is widely use in the project, but I have check the other usage and most of them are only use single one, so I think adding this margin won't affect other usage.

What do you think?😁

[XhmikosR]

The proper solution would be to not touch bd-placeholder-img but use our utils in this specific case instead.

I'm not sure about v4, it can probably stay as is unless the patch can be cherry picked cleanly :)

[XhmikosR]

Also, the brand page wraps now in master, we should probably fix this too. Generally there might be more places with such issues due to the master doc-related changes.

[SeasonLeee]

The proper solution would be to not touch bd-placeholder-img but use our utils in this specific case instead.

Thanks for reply! And yeah, you absolutely are right and darn it! I totally forgot that in bootstrap we have those space utilities! I'm sorry to make that awful and thoughtless "change one and affect everywhere" suggestion! SORRY!!!😫

_By the way, I used to use that helper class a lot when I am in charge of design. But lately the task assign to me is to translate other people's design and that design is totally messy, meaning each page or screen's element have different space or width, which is so.... then I have no choice but write another set of space helper class... I guess that's why I forget our mighty bootstrap have this feature..._

Anyway... I guess we can use bootstrap's .m-1 class in here to fix this issue then, right?😊

I'm not sure about v4, it can probably stay as is unless the patch can be cherry picked cleanly :)

Ugh... sorry I don't quite understand what that "the patch can be cherry picked cleanly" means.

Does it means someone has fixed it already? But commit on another branch?

I haven't use cherry pick before sorry... now, I'm on my way to google it...

[SeasonLeee]

Also, the brand page wraps now in master, we should probably fix this too. Generally there might be more places with such issues due to the master doc-related changes.

Do you mean the brand section under about navigation also have the same issue?

But I don't see anything wrong here...
the online working doc:

the link you in your comment: