Bootstrap: Is this correct rendering collapsed menu on mobile?

Created on 11 Sep 2017  路  6Comments  路  Source: twbs/bootstrap

image
image

css v4

Most helpful comment

maybe we should add some styles when dropdown are in a dark navbar 馃

All 6 comments

maybe we should add some styles when dropdown are in a dark navbar 馃

I've started working on this one today. Fixing it means lot of overwrite and context selectors under navbar.

@mdo What do you think? Is it worth it?

@kolkov @Johann-S I was working now on this issue and I got it to work:

Dark dropmenu

But the amount of high specificity code needed to achieve it for every breakpoint renders it pointless in my opinion.

I think this is something that can live in users code base. I like the idea of keeping the drop menu styles isolated from the navbar as a separate component, I think it's really smart.

@mdo If you think we should pursue the idea of a dark theme drop menu on navbar, let me know and I'll PR it.

IMO if this is accepted we'll have to do the same for primary navbar 馃
Btw awesome work as always @andresgalante

@Johann-S if we do the same for primary, it might make things better. Let me try that and PR it so you guys can evaluate the code

Closing this issue out because it is intended. I'll leave the PR open though for now to see if we should revisit this and add the extra CSS for it. My gut says no, but I'm open to more feedback.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

IamManchanda picture IamManchanda  路  3Comments

knownasilya picture knownasilya  路  3Comments

athimannil picture athimannil  路  3Comments

kamov picture kamov  路  3Comments

fohlsom picture fohlsom  路  3Comments