Boostnote: Nord and Vulcan themes don't work

[colineberly]

Current behavior

Both Nord and Vulcan are broken on v0.15.3 after update. They both seem to revert to the default theme. I have not checked console logs yet as I don't have the time right now.

Expected behavior

Themes should show their respective colors.

Steps to reproduce

Update to v0.15.3 and choose either theme.

Environment

• Boostnote version: 0.15.3
• OS version and name: macOS 10.13.6

[maximouche]

With default theme :

Code theme is now white text on white bakground.

[irimiab]

It happens only for indented code blocks (those which are under a bullet)

[Flexo013]

Confirmed on Windows 10 with 0.15.3.

[daiyam]

I've just seen the issue. I will fix it. I won't let my babies be broken... :blush:

[Flexo013]

This is solved as of Boostnote Legacy version 0.16.0.

Thanks for your contribution @daiyam ❤️

[vnmabus]

The "white text on white background" error is still happening for me in non-dark themes for indented code blocks in version 0.16.1.

[Flexo013]

@vnmabus Could you give a screenshot example?

I have tested this on 0.16.1 with both Nord and a non-dark theme in combination with light code blocks. I am unable to reproduce the issue.

[vnmabus]

Yes of course. This is in 0.16.1 with the default theme:

[Flexo013]

That's really odd.

This is what I get when using the default interface theme, with default styled code blocks. Could you check that both those settings are set to default? (Make sure that you don't confuse it with editor style.

We could try backing up your notes, then uninstalling entirely and reinstalling, because some theme file might be corrupt on your end.

[daiyam]

@vnmabus Can you specify the Interface Theme, the Preview's Code Block Theme and Preview's Custom CSS you are using, with a markdown example? I can't reproduce your issue.

[maximouche]

It occurs when there is a code block embedded in a bullet/numbered list

lalala 
bimbamboom
- bullet1
  hello
  ```
  some very smart code here
  ```
- bullet2

Here is the result :

Here a screenshot a the theme I use

[vnmabus]

Yes, at first I though it was only in Windows, but I tried installing the 0.16.1 version in Linux in a different PC (that previously had 0.14 and worked fine) and the same problem occurs.

[maximouche]

it's also present on 0.16.1 on OSX

[daiyam]

+1

[daiyam]

The issue is due to hard coded styles introduced by #3473 before I move them to browser/main/lib/dataApi/formatHTML.js.
I did remember wondering why it's there...

[vnmabus]

@vnmabus Can you specify the Interface Theme, the Preview's Code Block Theme and Preview's Custom CSS you are using, with a markdown example? I can't reproduce your issue.

The preview code block theme is "dracula" (I never changed it, maybe it was the default in previous versions?).