Boostnote: Image Gallery support for local image

Created on 24 Feb 2019 · 16Comments · Source: BoostIO/Boostnote

Current behavior

Currently the image gallery only support images with https URL, however the native URL for Boostnote (:storage/xxx/xxx) does not work.

The only way to get it works for now is to use absolute path like file explorer

Related Issue: #2465

Expected behavior

The expected behavior should be :storage style relative path should be work for Image Gallery

Steps to reproduce

Environment

Version :
OS Version and name :
Window 10
Boostnote 0.11.15

IssueHunt Summary

daiyam has been rewarded.

Backers (Total: $30.00)

boostio ($30.00)

Submitted pull Requests

- #3027 fix gallery on windows

Tips

Checkout the Issuehunt explorer to discover more funded issues.

- Need some help from other developers? Add your repositories on IssueHunt to raise funds.

IssueHunt has been backed by the following sponsors. Become a sponsor

bug rewarded on issuehunt

Source

noklam

All 16 comments

@daiyam Thanks for building this image gallery function, this is awesome. It would be great if it works for normal boostnote style URL. Otherwise the image URL could be easily broken when photos are moving around.

noklam on 24 Feb 2019

@noklam the issue seems to be with windows style URL :storage\xxx\xxx instead of :storage/xxx/xxx.

daiyam on 24 Feb 2019

👍1

@daiyam You are correct. the back slash "\" works fine though if it is a classic image

noklam on 24 Feb 2019

Same problem as https://github.com/BoostIO/Boostnote/issues/2834

ZeroX-DG on 27 Feb 2019

@ZeroX-DG I am not sure if they are the same problem. As noted I am using Boostnote 0.11.15 which include the bug fix from your reference issue already.

2834 shows local images issue with "/" and "\". As shown in my previous comment, "/" and "\" works perfectly fine with local image, it only fails for `Gallery`. They are probably a related issue, but `Gallery` is quite a new feature so maybe the last fix #2834 did not take care of `Gallery`?

If possible please re-open this issue.

noklam on 28 Feb 2019

@ZeroX-DG Also please notice the 2nd image of the issue, even with "\" the image render correctly if I use full path instead of :storage, I am using 0.11.15 already so this is a bug that have not been fixed.

noklam on 2 Mar 2019

@noklam I will try to make a fix this week-end

daiyam on 2 Mar 2019

👍1

@daiyam Great, thank you! I just start to learn electron today, looking forward to seeing your fix. :grinning:

noklam on 2 Mar 2019

@boostio has funded $30.00 to this issue.

Submit pull request via IssueHunt to receive this reward.
Want to contribute? Chip in to this issue via IssueHunt.
Checkout the IssueHunt Issue Explorer to see more funded issues.
Need help from developers? Add your repository on IssueHunt to raise funds.

IssueHuntBot on 23 May 2019

Sorry about the delay, I've forgotten to do the fix...

daiyam on 23 May 2019

@daiyam looks like there is a fix implemented? Will this fix be merged soon?

noklam on 19 Jul 2019

@noklam sorry, I have no idea...

daiyam on 19 Jul 2019

I have contacted Rokt33r about the PR containing the fix. With this I expect the fix to merged in the next few days. That also means that it will be part of the next release, which should be within a week.