Boostnote: code preview error

Created on 19 Jul 2018  路  4Comments  路  Source: BoostIO/Boostnote

Current behavior

  1. code preview show error

2018-07-19 21 34 09

php $ and single quotes error

  1. in the editor mode, when tap one * at the begin of new line, it become to **

Environment

  • Version :0.11.8 (0.11.8)
  • OS Version and name :10.13.6 (17G65)
bug

Most helpful comment

We still have a bug when sanitizing markdown. It is broken now. But, you can disable it!

screen shot 2018-07-20 at 0 15 31

All 4 comments

We still have a bug when sanitizing markdown. It is broken now. But, you can disable it!

screen shot 2018-07-20 at 0 15 31

Exported HTML also has an issue rendering it.

Markdown:

boostnote-issue-1

Rendered:

boostnote-issue-2

HTML Output

boostnote-issue-3

Environment

Boostnote version: 0.11.8
OS: Ubuntu 14.04 LTS

I installed latest Boostnote (because I reinstalled Linux) and now all my code snippets are broken with &quote;, ' (#2220) and other encodings or escapes (#2227). Snippets become hard to read. I cannot use the 'copy snippet' button, which I use daily, anymore. :angry:

@Rokt33r You really can't release a feature that causes something to be so blatantly broken.

Ideally there will be tests that will check the parsed output. Using your favorite CI with a github hook, any PR would be verified against these tests, and if something breaks, _it can not be merged_.

-update-

I see there are already tests? Are they ignored?
I guess code block test was just added. :+1:

-update-

I see @ZeroX-DG created #2230 to fix this. Please test/merge soon.

@Redsandro I'm sorry. I'll check it today.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

necan picture necan  路  3Comments

louiealmeda picture louiealmeda  路  3Comments

Rokt33r picture Rokt33r  路  3Comments

ryochack picture ryochack  路  3Comments

gavvvr picture gavvvr  路  3Comments