Boostnote: Note counter bug

Created on 9 May 2018  路  8Comments  路  Source: BoostIO/Boostnote

Current behavior

Storage1
 - Default : 0
 - Notebook1 : 2
Storage2
 - Notebook2 : 0

Expected behavior

Storage1
 - Default : 0
 - Notebook1 : 1
Storage2
 - Notebook2 : 0

Steps to reproduce

Storage1
 - Default : 0
 - Notebook1 : 1 (Note1)
Storage2
 - Notebook2 : 0
  1. Open "All Notes"
  2. Create a new note
Storage1
 - Default : 1 (Note2)
 - Notebook1 : 1 (Note1)
Storage2
 - Notebook2 : 0
  1. Move Note1 to Storage2:Notebook2
Storage1
 - Default : 1 (Note2)
 - Notebook1 : 0 
Storage2
 - Notebook2 : 1 (Note1)
  1. Move back to Storage1:Notebook1
Storage1
 - Default : 1 (Note2)
 - Notebook1 : 2 (Note1)  (Bug here)
Storage2
 - Notebook2 : 0
  1. Delete Note2
Storage1
 - Default : 0
 - Notebook1 : 1 (Note1)
Storage2
 - Notebook2 : 0
  1. Empty Trash
Storage1
 - Default : 0
 - Notebook1 : 2 (Note1)  (Bug here)
Storage2
 - Notebook2 : 0
  1. Click Notebook1
    Error:
    Uncaught TypeError: Cannot read property 'isPinned' of undefined

Environment

  • Version : 0.11.4
  • OS Version and name : Windows 10 x64

Please check this line. I'm not sure, though.
https://github.com/BoostIO/Boostnote/blob/90e8dd038da3786f2f6f0a9cfb9d4388da34082d/browser/main/store.js#L259

bug

Most helpful comment

@Rokt33r
Thanks, but @yasuokav has almost found the solution when he created the issue. I just confirm his solution and send pull request.

@yasuokav
I suppose you are the right person to get this reward.

All 8 comments

@yasuokav yes, you are right. need to update storageNoteMap here.

@kazup01 has boosted this issue with $20. Visit this issue on Issuehunt

@yosmoc Could you enter the below link, click start work and submit the url of the pull request?
https://issuehunt.io/repos/53266139/issues/1894

Then, we could reward you with $20. :)

@Rokt33r
Thanks, but @yasuokav has almost found the solution when he created the issue. I just confirm his solution and send pull request.

@yasuokav
I suppose you are the right person to get this reward.

@yosmoc Thank you!

@yasuokav has started working. Visit this issue on Issuehunt

@yasuokav has submitted output. Visit this issue on Issuehunt

@kazup01 has rewarded. Visit this issue on Issuehunt

Was this page helpful?
0 / 5 - 0 ratings