Desired Feature: Ability to disable/hide comments either globally and/or by page/chapter/book.
For my purposes (Technical Documentation for a small team), the comments section, for the most part, is an unneeded resource. I totally under the utility for others, but I do not intend on using it.
As a result, it would be nice to be able to disable it. I don't have a preference if that switch is global, by book, by chapter, or by page. Turning it off would remove an unused a page component and clean up the UI a bit.
Thank you!
Ethanb00
All 14 comments
I like this idea. Definitely like the idea of having book/chapter level control of comments.
I realize you want to keep this simple @ssddanbrown but would this be something that we could potentially look at adding to a Chapter/Book Settings menu?
Shackelford-Arden
on 3 Oct 2017
+1
slimjim91
on 4 Oct 2017
+1 for me!
criskolkman
on 10 Oct 2017
We would greatly appreciate this feautre as well
faizmali
on 20 Oct 2017
+1
galaxyfeeder
on 28 Oct 2017
Ok, there a few ways this can be done,
| Option | Role |
|-----------------------|----------------------------------------------|
| Global option | Only administrator can do this. |
| Option on the book | People who have modify access to the book |
| Option on the chapter | People who have modify access to the chapter |
| Option on the page | People who have modify access to the page |
I think row 1 and 2 should suffice. Let me know what you guys think. Once we have the requirements nailed down and @ssddanbrown has taken a look, I can submit a PR.
Abijeet
on 28 Oct 2017
@abijeet: I concur. Chapter and page are likely too granular. Per-book or global rights fit much better in terms of generating forms for documentation.
Thank you for your work!
Ethanb00
on 30 Oct 2017
Yeah, I think we should keep this at a global (admin) level. Will mark up for next feature release (v0.19). @Abijeet Feel free to go ahead with this one if you'd like.
ssddanbrown
on 11 Nov 2017
Have started working on this, few things to note -
- Added an option under app settings - Disable comments
- If this is turned on then,
- Adding comments is disabled.
- Existing comments will not be shown.
- The entire comments section is removed and no message is shown stating that comments are disabled.
Two things are debatable here,
- _Do we show a message stating that comments are disabled?_ Not sure if it's needed, but can be easily added.
- _Do we show existing comments?_ I removed them to save an extra query to fetch the comments.
Abijeet
on 15 Nov 2017
For what it's worth, my opinion would be that if you disable comments, don't show them. I like what you said about saving ourselves the extra query.
Shackelford-Arden
on 15 Nov 2017
I think the absence of comments is clear enough that they are disabled. My goal with disabling them is to have as little extra stuff as possible on the page.
Ethanb00
on 16 Nov 2017
IMHO @Abijeet choices are good ones. :)
jleroy
on 16 Nov 2017
I totally agree, Just hide all existence of comments with the option enabled.
ssddanbrown
on 19 Nov 2017
Featured now added by @Abijeet within #593. Will be in the next release.
ssddanbrown
on 7 Dec 2017
Related issues
Nedimko123
路
3Comments
alex2702
路
3Comments
stuartajd
路
4Comments
tpetrauskas
路
4Comments
mackcoding
路
3Comments
Most helpful comment
Ok, there a few ways this can be done,
| Option | Role |
|-----------------------|----------------------------------------------|
| Global option | Only administrator can do this. |
| Option on the book | People who have modify access to the book |
| Option on the chapter | People who have modify access to the chapter |
| Option on the page | People who have modify access to the page |
I think row 1 and 2 should suffice. Let me know what you guys think. Once we have the requirements nailed down and @ssddanbrown has taken a look, I can submit a PR.