Blueprint: Dismissing a Popover that is in a Dialog is closing the Dialog

Created on 14 Mar 2018  路  6Comments  路  Source: palantir/blueprint


Bug report

  • __Package version(s)__: 2.0.0-rc.2
  • __Browser and OS versions__: Chrome 64.0.3282.186, MacOS 10.13.3

closing-dialog

test site: https://tgreen7.github.io/blueprint-popover/
test repo: https://github.com/tgreen7/blueprint-popover

question

All 6 comments

This is expected, since the popover is outside the dialog, and outside clicks are allowed to close the dialog. You can get around this by disabling canOutsideClickClose on the Dialog or making the Popover usePortal={false}.

@adidahiya this has only started happening in v2 of blueprint though. Was this change in behavior expected?

@tnrich i'm not sure that's true--fairly sure this would happen in 1.0 too. we haven't touched the logic that closes on outside click.

@giladgray here is a test in 1.0 https://tgreen7.github.io/blueprint-popover-v1/
it seems to be working fine there. (repo https://github.com/tgreen7/blueprint-popover-v1)

(incorrect close, wrong issue number in PR)

other related issues exist

Was this page helpful?
0 / 5 - 0 ratings

Related issues

giladgray picture giladgray  路  3Comments

brsanthu picture brsanthu  路  3Comments

tgreenwatts picture tgreenwatts  路  3Comments

scottfr picture scottfr  路  3Comments

vinz243 picture vinz243  路  3Comments