Blueprint: Rename isDisabled to disabled

Created on 10 Jan 2017  路  8Comments  路  Source: palantir/blueprint

There's still a few instances of isDisabled here and there

API in discussion breaking change

All 8 comments

Remnants of a golden era. I'm going to miss those helping-verb prefixes.

+1 to @cmslewis; I also like the helping-verb prefixes. I guess the idea here is that we are mimicking the behavior of the HTML disabled attribute so we're trying to be consistent? I could see this going either way, but would get a little worried if we removed _all_ such prefixes from prop names ("should", "use", etc.)

What's important is staying consistent. This task is about choosing between isDisabled or disabled and sticking with it, but if you think there's a larger "do we use verb prefixes" task to look at, happy to file.

Slightly tangential but I wonder if we should just remove disabled altogether in some of these components in question; I'm thinking <Button />, <InputGroup /> and explicity say that we're proxying HTML props through to the underlying HTML.

we _do_ spread HTML props, but disabled exists in the interface precisely so it appears in the documentation. this came up recently in #396 where someone didn't realize that it was supported.

I just saw references to isActive, does this issue also apply to it?

@llorca take a look. Are we done with the isDisabled => disabled transition? Only a few search results left, none of them props:

https://github.com/palantir/blueprint/search?utf8=%E2%9C%93&q=isDisabled&type=

looks done indeed

Was this page helpful?
0 / 5 - 0 ratings

Related issues

scottfr picture scottfr  路  3Comments

adidahiya picture adidahiya  路  3Comments

adidahiya picture adidahiya  路  3Comments

sunabozu picture sunabozu  路  3Comments

havesomeleeway picture havesomeleeway  路  3Comments