Bloc: Can't run Bloc's performance tests

[justinmc]

Describe the bug
I can't get the tests in performance_tests/ to run to completion. Can anyone else? Am I doing something wrong?

To Reproduce
Steps to reproduce the behavior:

1. Start an Android emulator.
2. cd performance_tests/flutter_bloc/bloc_builder
3. flutter drive --target=test_driver/main.dart --driver=test_driver/driver/bloc_builder_performance_test.dart
4. Error:

Using device Android SDK built for x86 64.
Starting application: test_driver/main.dart
"build/app/outputs/apk/app.apk" does not exist.

FAILURE: Build failed with an exception.

* Where:
Build file '/Users/jmccandless/Projects/bloc/performance_tests/flutter_bloc/bloc_builder/android/app/build.gradle' line: 38

* What went wrong:
A problem occurred evaluating project ':app'.
> Could not find method targetSdkVersioni() for arguments [28] on DefaultConfig_Decorated{name=main, dimension=null, minSdkVersion=DefaultApiVersion{mApiLevel=16, mCodename='null'}, targetSdkVersion=null, renderscriptTargetApi=null, renderscriptSupportModeEnabled=null, renderscriptSupportModeBlasEnabled=null, renderscriptNdkModeEnabled=null, versionCode=null, versionName=null, applicationId=com.example.performancetests, testApplicationId=null, testInstrumentationRunner=null, testInstrumentationRunnerArguments={}, testHandleProfiling=null, testFunctionalTest=null, signingConfig=null, resConfig=null, mBuildConfigFields={}, mResValues={}, mProguardFiles=[], mConsumerProguardFiles=[], mManifestPlaceholders={}, mWearAppUnbundled=null} of type com.android.build.gradle.internal.dsl.DefaultConfig.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 0s
Running Gradle task 'assembleDebug'...
Running Gradle task 'assembleDebug'... Done                         1.3s
Gradle task assembleDebug failed with exit code 1

Expected behavior
Tests run and pass.

*Logs *

$ flutter doctor -v
[✓] Flutter (Channel selection-overflow-ios, v1.15.4-pre.240, on Mac OS X 10.15.3 19D76, locale en-US)
    • Flutter version 1.15.4-pre.240 at /Users/jmccandless/Projects/flutter
    • Framework revision 4157936dd2 (6 days ago), 2020-03-26 10:59:41 -0700
    • Engine revision 3a2cc95533
    • Dart version 2.8.0 (build 2.8.0-dev.15.0 9dfd0127da)


[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at /Users/jmccandless/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 28.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.2.1, Build version 11B500
    • CocoaPods version 1.8.4

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 3.5)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 42.1.1
    • Dart plugin version 191.8593
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)

[✓] Connected device (3 available)
    • Android SDK built for x86 64 • emulator-5554 • android-x64    • Android 9 (API 28) (emulator)
    • Chrome                       • chrome        • web-javascript • Google Chrome 80.0.3987.149
    • Web Server                   • web-server    • web-javascript • Flutter Tools

• No issues found!

[felangel]

Hi @justinmc 👋
Thanks for opening an issue!

Unfortunately, I haven't been keeping these tests up-to-date and was even debating removing them. Can you provide some more context around why you want to run them? Thanks! 👍

[justinmc]

No problem! Really I was just curious. I work on Flutter and was digging through some of the more popular Flutter-related repos on Github.

Maybe removing them is the best call if they're not being used at all right now. Or at least maybe a note about the status and future plans for these tests in the READMEs in the performance_tests directory.

The unit tests in packages/ work for me.

[felangel]

Went ahead and removed them in https://github.com/felangel/bloc/commit/73895c5b3e158cae0d0ee5703e1d4341df753681 👍

[justinmc]

Sounds good to me, thanks for the quick response.