Blink: The whole app just broke after installing a theme

Created on 3 Oct 2018  路  6Comments  路  Source: blinksh/blink

Hi, just got this app, but after trying to add this theme generated by terminal.sexy, the app started only displaying a black screen with a keyboard.

t.prefs.set('background-color', "#000000");
t.prefs.set('foreground-color', "#c5c8c6");
t.prefs.set('cursor-color',     "#c5c8c6");
t.prefs.set('color-palette-overrides', ["#282a2e","#a54242","#8c9440","#de935f","#5f819d","#85678f","#5e8d87","#707880","#373b41","#cc6666","#b5bd68","#f0c674","#81a2be","#b294bb","#8abeb7","#c5c8c6"]);

This theme file is invalid (no underscore after prefs), but breaking the whole terminal like that, requiring reinstalling the app is... pretty bad.

Most helpful comment

Ok, app will show alert now. And try to fallback to defaults. So you can go config and change the theme.

img_0081

All 6 comments

Hi @SilverEzhik,

Where did you find this syntax for theme (it is outdated)? We need to update that place :)

We support terminal.sexy json format. Take a look at wwdc16.js theme.

Can't find any place with this syntax.

You script will work if you replace withprefs_

t.prefs_.set('background-color', "#000000");
t.prefs_.set('foreground-color', "#c5c8c6");
t.prefs_.set('cursor-color',     "#c5c8c6");
t.prefs_.set('color-palette-overrides', ["#282a2e","#a54242","#8c9440","#de935f","#5f819d","#85678f","#5e8d87","#707880","#373b41","#cc6666","#b5bd68","#f0c674","#81a2be","#b294bb","#8abeb7","#c5c8c6"]);

But this syntax is deprecated.
Please you syntax as in wwdc16 theme or with term_set

term_set('background-color', "#000000");
term_set('foreground-color', "#c5c8c6");
term_set('cursor-color',     "#c5c8c6");
term_set('color-palette-overrides', ["#282a2e","#a54242","#8c9440","#de935f","#5f819d","#85678f","#5e8d87","#707880","#373b41","#cc6666","#b5bd68","#f0c674","#81a2be","#b294bb","#8abeb7","#c5c8c6"]);

Yeah, I went and double checked and the missing underscore was my fault. I'd still leave this bug open considering how badly things broke, though :V

Yep you are right, that is bad UX.
Sorry for that.
Will fix it.

Ok, app will show alert now. And try to fallback to defaults. So you can go config and change the theme.

img_0081

Thank you. Closing this.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

treyharris picture treyharris  路  3Comments

dlasky picture dlasky  路  4Comments

jasondinh picture jasondinh  路  3Comments

goerz picture goerz  路  4Comments

proportional picture proportional  路  3Comments