Is there any plans to conform flake8-commas?
yutkin
All 4 comments
I'm not familiar with this tool, but glancing at the README it should mostly already match Black's behavior. What specific change are you looking for?
JelleZijlstra
on 5 Oct 2018
After usage of Black, I still have several warnings from flake8-commas (C812, C815, C816).
For example, line 546 causes C812 warning.
545 fill_data = missing_values_filling_needed(
546 get_filters(report_query.get("metrics", []))
547 )
👍1
I think the idea with black is that you'd remove flake8-commas because black will automatically rewrite your code to avoid the things it _would_ lint for.
The one disagreement between the two tools is that black will not put a comma on single line calls (an aside: this is also the only inconsistency between black and add-trailing-comma)
asottile
on 10 Oct 2018
👍4
Doesn't sound like this is currently actionable.
JelleZijlstra
on 5 May 2019
Was this page helpful?
0 / 5 - 0 ratings
Related issues
ambv
路
51Comments
Lukas0907
路
66Comments
kindjacket
路
21Comments
Kristinita
路
28Comments
lig
路
84Comments
Most helpful comment
I think the idea with black is that you'd remove
flake8-commasbecauseblackwill automatically rewrite your code to avoid the things it _would_ lint for.The one disagreement between the two tools is that
blackwill not put a comma on single line calls (an aside: this is also the only inconsistency between black and add-trailing-comma)