Bitcoinjs-lib: update comment to say bech32 as well?

Created on 10 Jan 2018  路  1Comment  路  Source: bitcoinjs/bitcoinjs-lib

https://github.com/bitcoinjs/bitcoinjs-lib/blob/e0f24fdd46e11533a7140e02dc43b04a4cc4522e/src/transaction_builder.js#L607

this is pedantic I know lol but im using the library to walk my self through how segwit addresses and transactions are made

I noticed on this line it says

// Attempt to get a script if it's a base58 address string

should it say?

// Attempt to get a script if it's a base58 or bech32 address string

how to / question / docs

Most helpful comment

Thanks for the report!

Closing in favor of #980

>All comments

Thanks for the report!

Closing in favor of #980

Was this page helpful?
0 / 5 - 0 ratings

Related issues

askucher picture askucher  路  3Comments

silence-may picture silence-may  路  3Comments

ghost picture ghost  路  3Comments

yakitorifoodie picture yakitorifoodie  路  3Comments

coingeek picture coingeek  路  4Comments