Bitcoinjs-lib: bscript.compile, undefined is not a function (react-native), circular dependency

[mc-tracker]

Hi, I'm developing an rn project with bitcoinjs-lib. Previously, I have fixed compatible issues by rn-nodeify.
Unfortunately, this latest version which contains template module cannot be resolved as before.
Transaction creation is always failed when called bscript.compile, because script which was required by out.js is {}.
But the Types is required well,like the code in out.js as below:

var bscript = require('../../script')
var types = require('../../types')

I have changed and compared, But got nothing.
could anyone please give me some suggestion?Thanks in advance

[dcousens]

Can you please post what your code is and the exact error you receive.

[mc-tracker]

Ok ,let me show you:
My code:

    toOutputScript_ext: function (address, curr_type) {
        var network = bitcoin.getNetwork(curr_type);//network || networks.bitcoin
        var decode = AddressGenService.fromBase58Check_ext(address);

        if (decode.version === network.pubKeyHash){
            return bitcoin.script.pubKeyHash.output.encode(decode.hash);//**error occurs at here**
        }
        if (decode.version === network.scriptHash) {
            return bitcoin.script.scriptHash.output.encode(decode.hash);
        }

        //兼容
        if( (curr_type === "LTC") && ( decode.version === network.scriptHash2)){
            return bitcoin.script.scriptHash.output.encode(decode.hash);
        }

        throw new Error(address + ' has no matching Script');
    },

Error:

After struggled with this problem for hours, I found that the script in out.js is {}
Paste bitcoinjs-lib's code also:

// OP_DUP OP_HASH160 {pubKeyHash} OP_EQUALVERIFY OP_CHECKSIG
var bscript = require('../../script')
var types = require('../../types')
var typeforce = require('typeforce')
var OPS = require('bitcoin-ops')
console.info(bscript);//it should not be null

function check (script) {
  var buffer = bscript.compile(script)

  return buffer.length === 25 &&
    buffer[0] === OPS.OP_DUP &&
    buffer[1] === OPS.OP_HASH160 &&
    buffer[2] === 0x14 &&
    buffer[23] === OPS.OP_EQUALVERIFY &&
    buffer[24] === OPS.OP_CHECKSIG
}
check.toJSON = function () { return 'pubKeyHash output' }

function encode (pubKeyHash) {
  typeforce(types.Hash160bit, pubKeyHash)

  return bscript.compile([
    OPS.OP_DUP,
    OPS.OP_HASH160,
    pubKeyHash,
    OPS.OP_EQUALVERIFY,
    OPS.OP_CHECKSIG
  ])
}

function decode (buffer) {
  typeforce(check, buffer)

  return buffer.slice(3, 23)
}

module.exports = {
  check: check,
  decode: decode,
  encode: encode
}

[mc-tracker]

@dcousens for your infomation

[dcousens]

Sounds like a require issue, circular dependency or something.

How is your project structured?

[mc-tracker]

Sorry, I'm not sure what did you say, are there any references? In my project, only require bitcoinjs-lib rather than it's sub modules.@dcousens

[mc-tracker]

This is require detail in the js file which required bitcoinjs-lib

var bitcoin = require('./bitcoin.js');
var bs58check = require('bs58check');

[dcousens]

If you run node bitcoinjs-lib/src/templates/pubkeyhash/output.js with your added console.log(bscript)... is it still {}?

[dcousens]

@maxcloudwgh wait, you have browserified it already? You don't need to browserify unless you are deploying to a web page, and even then, browserify your entire project, not bitcoinjs-lib specifically.

var bitcoin = require('bitcoinjs-lib')

// ...

[mc-tracker]

No, I'm not use browserify, It was only compressed by the tool build in Rn

[mc-tracker]

Be more clear,built in react native

[dcousens]

@maxcloudwgh I think your build tool has had a problem somewhere.

[mc-tracker]

According to your question, I just review my code again, maybe the code in bitcoin.js have some problem? the code of bitcoin.js as below

var bitcoin = require('bitcoinjs-lib');

bitcoin.getNetwork = function (curr_type) {
//do something
};

[mc-tracker]

bitcoinjs-lib is required in bitcoin.js and add some custom functions to it, is it a bad use?

[dcousens]

@maxcloudwgh no, that should be fine.
Are you testing this with node or react-native?

[mc-tracker]

Yeah, i had test it's send method under node environment, it works. Same method failed in RN

[mc-tracker]

FYI, The compressed Tool built in RN only take effect when assemble an release build,the error I mentioned was occurs in debug build.@dcousens

[mc-tracker]

so far I'm not thinks it's an issue of bitcoinjs-lib , it should be an compatible issue between RN and bitcoinjs-lib :).

[dcousens]

@maxcloudwgh if you find a solution, please post the solution here incase we can help alleviate the underlying problem, react-native or otherwise

[mc-tracker]

My pleasure @dcousens

[dcousens]

@maxcloudwgh, it seems @WillCoco has the same issue.

Did this issue only appear in the latest release (3.2.0) for the two of you? Or are you both new and only having this issue now?

[mc-tracker]

@dcousens I'm sure it works fine on old release.just now I test it on old release again, it still works well

[mc-tracker]

FYI, the old version number is

[dcousens]

@maxcloudwgh what about 3.0.0 (not ^3.0.0, not 3.2.0)?

[mc-tracker]

Ok ,I will have a try, but I think template modules cause this issue.@dcousens

[dcousens]

@maxcloudwgh the template modules have a circular dependency with bitcoin.script, which is probably the reason it is failing.

I might move the template export injection from bitcoin.script to index.js, as it is purely a convenience for users, and not necessary in bitcoin.script.
This wouldn't be a breaking change.

[mc-tracker]

yeah, it failed on 3.0.0 as expected just now, maybe circular dependency is the real reason.@dcousens

[mc-tracker]

@dcousens if you finished, please let me know

[dcousens]

@maxcloudwgh please see #907, download and test :+1: