Bisq: Update legacy assets with proper AddressValidator

[devinbileck]

I have split this into a separate issue from https://github.com/bisq-network/bisq/issues/1815#issuecomment-433112999.

A lot of legacy assets are using the deprecated DefaultAddressValidator which provides very basic and insufficient validation (non-null and non-empty). Any new asset implementations are required to provide their own AddressValidator implementation. To bring these legacy assets up to date and in order provide proper validation, they should be updated with an appropriate AddressValidator.

However, as part of https://github.com/bisq-network/bisq/pull/1861, a majority of these legacy assets will be delisted. So will need to review this once all untraded assets have been delisted.

[ripcurlx]

@devinbileck Feel free to take this bounty 😄

[devinbileck]

@ripcurlx There is a bounty for this? But feel free to assign it to me, I can take a look when I get a chance.

[ripcurlx]

@devinbileck You've just added a bounty label on it 😄

[ManfredKarrer]

@devinbileck Bounties are more for attracting new devs. Its always hard to estimate in advance value of those, so as you are already a experienced Bisq contributor I think its easier if you just work on it and request based on your efforts.

[niyid]

Hello @devinbileck

Is this being worked on? I can "help". :-D

[devinbileck]

@niyid No I have not looked into this. Feel free to take over :)

[niyid]

For clarification; I believe the requirement is to do a check for references to the deprecated DefaultAddressValidator and replace those instances with more functional address validators. Correct?

I do not have to wait for the asset delisting do I?

[devinbileck]

For clarification; I believe the requirement is to do a check for references to the deprecated DefaultAddressValidator and replace those instances with more functional address validators. Correct?

Correct.

I do not have to wait for the asset delisting do I?

No.

[niyid]

Thanks Devin. I will get right on it.

On Tue, Jul 23, 2019 at 8:29 PM Devin Bileck [e-mail]
wrote:

For clarification; I believe the requirement is to do a check for
references to the deprecated DefaultAddressValidator and replace those
instances with more functional address validators. Correct?

Correct.

I do not have to wait for the asset delisting do I?

No.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/bisq-network/bisq/issues/1896?email_source=notifications&email_token=AE2MWR6XKNKBPVF6YTUFK7DQA5LXZA5CNFSM4GCQL56KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2UFY2A#issuecomment-514350184,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AE2MWR6KZVBVAO4QVBPUEN3QA5LXZANCNFSM4GCQL56A
.

[niyid]

Thanks Devin. You may reassign to me, please.

Regards.

[devinbileck]

I am unable to assign you. Would need @ripcurlx or @sqrrm to do that. But I have unassigned myself.

[niyid]

Great. Thanks for letting me know.

On Wed, Jul 24, 2019, 17:01 Devin Bileck [e-mail] wrote:

I am unable to assign you. Would need @ripcurlx
https://github.com/ripcurlx or @sqrrm https://github.com/sqrrm to do
that. But I have unassigned myself.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/bisq-network/bisq/issues/1896?email_source=notifications&email_token=AE2MWR74GQWOMYQ3P4X3JSDQBB4G5A5CNFSM4GCQL56KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2WZZ4I#issuecomment-514694385,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AE2MWRYQZGAJZIQWAV6POALQBB4G5ANCNFSM4GCQL56A
.

[niyid]

Hi @ripcurlx

Can you please assign this task to me?

Regards.

[sqrrm]

@niyid assigned