Binderhub: Refactor index.js

Created on 15 Dec 2017  Â·  3Comments  Â·  Source: jupyterhub/binderhub

First line of index.js says:

/* If this file gets over 200 lines of code long (not counting docs / comments), start using a framework

The file is now over 200 lines long, and the lack of architecture there is causing higher than needed friction for implementing new features. Would be great if we can refactor it into using modern JS best practices - using a package manager, modularized imports, components (React?), etc.

architecture discussion

Most helpful comment

All 3 comments

Let's go ahead and use React to refactor as it's lightweight yet powerful and there's experience within the team on using it.

I hear that react is a good framework to use if you like python ;-)

On Tue, Dec 19, 2017, 4:05 PM Carol Willing notifications@github.com
wrote:

Let's go ahead and use React to refactor as it's lightweight yet powerful
and there's experience within the team on using it.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jupyterhub/binderhub/issues/356#issuecomment-352785069,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABwSHY6OlW7RVx7F6g3Y_QzZv93XPey_ks5tB9CwgaJpZM4RD9RB
.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

yuvipanda picture yuvipanda  Â·  4Comments

ashtonmv picture ashtonmv  Â·  6Comments

stuaxo picture stuaxo  Â·  6Comments

choldgraf picture choldgraf  Â·  7Comments

yuvipanda picture yuvipanda  Â·  5Comments