Betonquest: [Question/Feature] Compatibility with Brewery Plugin

[ParadiddlePride]

I'm unsure if this was ever an option or still is, but I am currently completely unsure how to use Brewery plugin alcohols within the quests. Even simply checking to see if it's in a players inventory doesn't seem to currently be possible, or I'm just writing the item's information wrong.

Within the items file of Betonquest:
brewtest: 373 name:&fRussian_Vodka effects:WEAKNESS:?:?,POISON:?:? lore:_;&73-times_Distilled

The brew within Brewery:

   7:
      name: Lousy Vodka/Vodka/Russian Vodka
      ingredients: 
      - POTATO_ITEM/10
      cookingtime: 15
      distillruns: 3
      age: 0
      color: BRIGHT_GREY
      difficulty: 4
      alcohol: 20
      effects:
      - WEAKNESS/15
      - POISON/10

[joblo2213]

There are two possible ways to simply achive this without having to worry at all about this:

1. Just give yourself the finished brew and use /q itemcommand to register the item. Then you can also have a look how the config file has to look correctly.

2. @Namnodorel created a integration for exactly that (see #626 ). You'll have to use one of the latest dev versions to use this.
   There is only one problem: Namnorodel didn't create any form of documentation so you'll somehow have to figure it out yourself.

   What I can tell you is that there are the following things:

   • hasbrew condition to test if player has a brew in its inventory
     (Usage: hasbrew <amount> <brewery brew name>)

   • givebrew event to give a brew to a player
     (Usage: givebrew <amount> <quality> <brewery brew name>)

   • takebrew event to take a brew from a plyer
     (Usage: takebrew <amount> <brewery brew name>)

   • druk condition to check if a player is drunk
     (Usage: drunk <drunkness>)

   • drunkquality condition to check if the players drunk quality is higher than specified
     (Usage: drunkquality <quality>)

[ParadiddlePride]

I learn a new way to use this plugin every day it seems xD thank you, I'll be trying at least the first method tonight when I finish up at work.

[ParadiddlePride]

Now using the latest dev build, only cannot seem to get the plugin to recognize the brew.

19.03 04:25:21 [Server] ERROR [BetonQuest] Error in 'EasterEvent.brewbunnygoldenbrew' condition (hasbrew): There is no brewing recipe with the name Golden Duckling!
19.03 04:25:21 [Server] ERROR [BetonQuest] Error in 'EasterEvent.brewbunnythumperbrew' condition (hasbrew): There is no brewing recipe with the name A Thumper's RumRunner!

From my conditions file:

brewbunnygoldenbrew: hasbrew 1 §fGolden_§6Du§eck§6li§eng
brewbunnythumperbrew: hasbrew 1 §fA_§dThumper's_§6R§6u§2m§2R§aun§dner

From the Brewery config:

   13:
      name: Golden &6Du&eck&6li&eng
      ingredients:
      - EGG/1
      - GOLD_NUGGET/3
      - WOOL,4/2
      cookingtime: 3
      distillruns: 2
      color: ORANGE
      difficulty: 1
      alcohol: 5
      effects:
      - NIGHT_VISION/1/180
      - HEAL/1/180
      - INCREASE_DAMAGE/1/180
   14:
      name: A &dThumper's &6R&6u&2m&2R&aun&dner
      ingredients:
      - RABBIT_FOOT/2
      - CARROT/6
      - SUGAR/4
      cookingtime: 8
      distillruns: 2
      wood: 4
      age: 2
      color: RED
      difficulty: 6
      alcohol: 48
      effects:
      - SPEED/2/60-180
      - JUMP/2/60-180
      - CONFUSION/2/30

The items generated using /q item [name]

thumperrumbrew: POTION data:0 name:§fA_§dThumper's_§6R§6u§2m§2R§aun§dner lore:;§72-times_Distilled;§72_Years_Barrel_aged
  type:STRENGTH effects:REGENERATION:1:-3
goldenducklingbrew: POTION data:0 name:§fGolden_§6Du§eck§6li§eng lore:;§72-times_Distilled
  type:FIRE_RESISTANCE effects:REGENERATION:1:-3

I did try reading through some of the documentation to figure out where I'm supposed to reference the recipes. I even tried creating a recipes.yml where the event/condition/objective/etc files are. So unsure as to where the disconnect is happening

[joblo2213]

Atm I would guess hasbrew 13 as you have 13 as key for your config section.

But I can have a closer look at the code this evening.

[joblo2213]

So looking at both brewery code and BetonQuest code I come to the following result:
It should work with the name like it is defined in the config of brewery ( replaced by _).
In your case it should be:
hasbrew 1 A_&dThumper's_&6R&6u&2m&2R&aun&dner
and
hasbrew 1 Golden_&6Du&eck&6li&eng

Hope I could help, please let me know if this works^^

[ParadiddlePride]

I just tested everything. Perhaps before I wasn't using the underscores. Regardless, I got all 5 of the brew related events/conditions to work.

Our team of content creators are very excited about this, and I'm grateful for your help :)
Hopefully these can be added to the main builds soon, dev builds honestly scare me with their possibility for bugs xD Thanks again!

[joblo2213]

Actually the current dev builds has as far as I know less bugs than the 1.9.6 release 😟
The problem is that Co0sh (who is creating the releases) currently has verry little time for maintaining the plugin.