Betonquest: Global Location tag

[MWFIAE]

Hi,

after completing a global location a tag is set, so that it doesn't trigger again. This is done automatically in betonquest. (which doesn't seem to be proper, but ok we could work around it, if so desired. )

But look at the tag that is generated:

I think it would be right if it was:
packages-orte.global_piratenbucht

With "packages-orte" being my packagname and "piratenbucht" being the name of the global location.

I think nothing game breaking here, it's just not pretty :)

[Co0sh]

Tags are added automatically for convenience. It's a pretty old mechanism and it's not really changeable right now. Neither is changing the format of the tag, however ugly it appears.

We could however replace the system with something entirely else. The global locations could be removed from the documentation (but left in code, for backwards compatibility) and the new system could take their place.

[MWFIAE]

Well what I always wanted and what could replace the global location would be a global objective.
Some objectives that every player would have and that doesn't need to be started explicit.

So just like the global locations, but with more variation.

[Co0sh]

Hmm, there's an easy way of doing it, but still dependent on having tags. Imagine having an additional, optional global argument in every objective. When the player joins the server (or the plugin is reloaded, then it's executed for all players) BetonQuest could look at all objectives and start the ones with global argument for all players missing package.global-objectiveID tag. Then it would add that tag for this player.

The good thing about this setup is that if you want to start the objective again or cancel it before it's completed you just handle it like a regular objective (because it is).

If you think using tags for this is a bad idea for some reason then we could eventually store them in a separate database table.

[MWFIAE]

Tags are way better than a separate table, as we are already able to manipulate them to our liking (muhahaha.... ähm sorry).
It's just that I don't like the idea to have tags by convention^^ (I mentioned something like this in the npc hider issue a while ago)

But in this case I think you are right, we would be able to add the persistent flag so it would never really stop and so we shouldn't really have a need to handle that all by ourselves :)

And I can understand your point of view as you want to make it as easy as possible to get started.
(Betonquest is hard enough as is :) )

[MWFIAE]

Closing this as the new feature will be handled in issue #636 :+1: