Bentobox: Coop not removing after logout

[Kryniowesegryderiusz]

Description
Coop is not removed from cooped player after logout (does not work, when leader or member or even cooped player loggs out)

Server Information:

[Please complete the following information:]

• Database being used (Flat file, MySQL, Mongo): MySQL
• OS: Ubuntu
• Java Version: 8
• BentoBox version: 0.14.0
• Addons installed?

BSkyBLock 0.5.0
WelcomeWarps 0.1.0
Level 0.1.0
Challenges 0.0.3

[Poslovitch]

Can confirm the bug is occuring on the latest version, as I cannot find any occurences of "coop rank removal" in the code: https://github.com/BentoBoxWorld/bentobox/search?l=Java&q=coop.

[Poslovitch]

@tastybento I will need help on this one, I don't know how I could get the islands the "target" is cooped on. Do you have any ideas on that?

[tastybento]

I’ll look at this. I remember now that this feature was not finished after I added the ranks. Coop is currently not removed when the inviter logs out.

[Poslovitch]

@tastybento I'm assigning you to this issue.

[tastybento]

Yep. I’m on holiday this week so I can work on some of these!

[tastybento]

So, I've added the functionality to remove coops when the cooped player logs out and also remove all coops if the server is shutdown. I think that should be sufficient. If the inviter wants the player to be un-cooped, they can use the command to do that. Does that work or did I miss something?

[Kryniowesegryderiusz]

Maybe also add someting like, if player who added visitor to coop loggs out it removes from coops. Ex. when someone lost connection, and cant uncoop. Like in askyblock

[tastybento]

Yeah, I understand but I purposely didn't add that because it requires another database to store a history of who invited who. Let me think about that one.

[Kryniowesegryderiusz]

So maybe just if all usrs added to island loggs off?

[Poslovitch]

Might be a bit "too much", I think...

[tastybento]

@Kryniowesegryderiusz That may be possible. If the last true member or above in rank logs off then all coops ranks could be cleared.

[Kryniowesegryderiusz]

That would be enough I think

[tastybento]

I'm going to work on this now...

[tastybento]

Done in commit 3dd7126ca903ba78b365ece3c0c8111496809a00