Beats: metricbeat - vsphere module config example is wrong

[alextxm]

The default file for the vsphere module (modules.d/vsphere.yml.disabled) contains an invalid configuration example:
metricsets: ["datastore, host, virtualmachine"]

but this will cause metricbeat to report an invalid metricsets error at startup.
The correct configuration is:

metricsets: ["datastore", "host", "virtualmachine"]

Please also note the same error can be found in the official docs at https://www.elastic.co/guide/en/beats/metricbeat/6.0/metricbeat-module-vsphere.html

Tested with metricbeat 6.0.0-rc1 on Windows Server 2008R2.

[andrewkroh]

Thanks for the report. If anyone wants to fix contribute a PR the problematic file is metricbeat/module/vsphere/_meta/config.yml. After editing the file you need to run make update from inside the metricbeat dir.

[sitaramshelke]

Hey, @andrewkroh I can take this if available. Looks pretty straightforward.

[ruflin]

@sitaramshelke go for it :-)

[amandahla]

Great! I made the correction here too time ago (https://github.com/elastic/beats/pull/4883) but we had problems with Vic :|

[sitaramshelke]

Hello @amandahla, I can see changes in the commit. @ruflin So should we have a separate PR just for this change?
Let me know what you think.

[ruflin]

@sitaramshelke I suggest to do a separate PR to get it in quicker.