Beaker: Video files crash Beaker, possibly related to size

[pfrazee]

Operation System: Linux
Beaker Version: 0.7.1

Tim reported a crash bug in linux where an FLV of around 983mb crashed Beaker. This only happened when reading the file from staging. It's possible there's some code that's trying to allocate a buffer of that size, when it ought to be streaming.

[pfrazee]

I spent some time debugging this and found I was able to produce crashes in both OSX and Linux. Both of them are segfaults, which suggests to me there's a bad pointer reference in the underlying C++.

I'm going to see if I can produce a test-case and file an issue with electron.

[pfrazee]

Filed https://github.com/electron/electron/issues/9635

[soyuka]

Interestingly, I'm able to reproduce this issue with <audio src="dat://foo.mp3"> but not with <video src="dat://foo.mp4">. Will keep updated on my findings if any.

Versions at the time of test:

[louiscenter]

Like @soyuka, I've been able to reproduce this crash using an <audio> element. Playing an .mp3 file from the local dat:// archive will bork the browser anywhere after 30 seconds to 1 minute.

I think this was answered on IRC, but I wanted to make sure it's documented in a GH issue for others to see: does this PR (https://github.com/electron/electron/pull/10918) fix the <audio>/<video> bug?

[pfrazee]

@louiscenter yes. We'll hopefully have a new version of beaker with the fix soon.

[pfrazee]

Fixed now that we have electron 1.8.2-beta.2. Will release soon!