Bazel: Release 0.28 - July 2019 (stable)

Created on 6 Jun 2019  路  14Comments  路  Source: bazelbuild/bazel

Target RC date - July 1st, 2019
This release will have no breaking changes.

See the blog post for some details

release

Most helpful comment

0.28.0 introduced a breaking change with the behavior of --experimental_google_legacy_api.

To reproduce, clone https://github.com/bazelbuild/intellij and run bazel build //aswb:aswb_bazel_zip --define=ij_product=android-studio-beta.

0.28.0:

jingwen@jingwen-sea:~/code/intellij$ USE_BAZEL_VERSION=0.28.0 bazel build //aswb:aswb_bazel_zip --define=ij_product=android-studio-beta --nobuild
ERROR: /usr/local/google/home/jingwen/code/intellij/aspect/intellij_info_impl.bzl:105:25: android_common is experimental and thus unavailable with the current flags. It may be enabled by setting --experimental_google_legacy_api
ERROR: /usr/local/google/home/jingwen/code/intellij/aswb/BUILD:212:1: error loading package 'aspect': Extension 'aspect/intellij_info_impl.bzl' has errors and referenced by '//aswb:aspect_directory'
ERROR: Analysis of target '//aswb:aswb_bazel_zip' failed; build aborted: Analysis failed
INFO: Elapsed time: 0.200s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (0 packages loaded, 0 targets configured)
    currently loading: java ... (3 packages)

0.27.2:

jingwen@jingwen-sea:~/code/intellij$ USE_BAZEL_VERSION=0.27.2 bazel build //aswb:aswb_bazel_zip --define=ij_product=android-studio-beta --nobuild
WARNING: Waiting for server process to terminate (waited 5 seconds, waiting at most 60)
Starting local Bazel server and connecting to it...
INFO: Analyzed target //aswb:aswb_bazel_zip (59 packages loaded, 2137 targets configured).
INFO: Found 1 target...
INFO: Deleting stale sandbox base /usr/local/google/home/jingwen/.cache/bazel/_bazel_jingwen/566de91536493bd30d1fb02c05327dbd/sandbox
INFO: Elapsed time: 10.472s
INFO: 0 processes.
INFO: Build completed successfully, 0 total actions

This affects all Bazel 0.28.0 users using any of the stable IntelliJ plugins.

cc @c-parsons

https://github.com/bazelbuild/bazel/commit/78e5fe2b6bcb2cd33c5d09221b47318a127ac2b0 is the breaking change for android_common. We should either rollback this change, or rollforward by whitelisting android_common. It's not feasible to ask all IntelliJ users to add --experimental_google_legacy_api.

I'll take on an action item to expand the IntelliJ CI coverage to ensure that this doesn't happen again: https://github.com/bazelbuild/intellij/pull/977

Update: please cherry pick https://github.com/bazelbuild/bazel/commit/a0af170f87c8230fcd8860599b983df097b646bd into 0.28.0.

All 14 comments

Status of Bazel 0.28

I plan to keep this message up to date during the release process and provide the important information.

To report a release-blocking bug: file a bug, use the Release blocker label, and cc @laurentlb. Release blockers are regressions in Bazel relative to Bazel 0.26 or Bazel 0.27.

Task list:

Please cherry-pick https://github.com/bazelbuild/bazel/commit/6d0b14b95a71175362030b4811ca74512b00a890 to fix 0.26 -> 0.27 regression https://github.com/bazelbuild/bazel/issues/8723. See also https://github.com/bazelbuild/bazel/issues/7816#issuecomment-508392622

0.28.0rc2 was created using:
scripts/release/release.sh create --force_rc=2 0.28.0 2e374a9c6e3d4ed71f0145de287c4b2fe43c76d6 6d0b14b95a71175362030b4811ca74512b00a890

The binaries are available here: https://releases.bazel.build/0.28.0/rc2/index.html

0.28.0 introduced a breaking change with the behavior of --experimental_google_legacy_api.

To reproduce, clone https://github.com/bazelbuild/intellij and run bazel build //aswb:aswb_bazel_zip --define=ij_product=android-studio-beta.

0.28.0:

jingwen@jingwen-sea:~/code/intellij$ USE_BAZEL_VERSION=0.28.0 bazel build //aswb:aswb_bazel_zip --define=ij_product=android-studio-beta --nobuild
ERROR: /usr/local/google/home/jingwen/code/intellij/aspect/intellij_info_impl.bzl:105:25: android_common is experimental and thus unavailable with the current flags. It may be enabled by setting --experimental_google_legacy_api
ERROR: /usr/local/google/home/jingwen/code/intellij/aswb/BUILD:212:1: error loading package 'aspect': Extension 'aspect/intellij_info_impl.bzl' has errors and referenced by '//aswb:aspect_directory'
ERROR: Analysis of target '//aswb:aswb_bazel_zip' failed; build aborted: Analysis failed
INFO: Elapsed time: 0.200s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (0 packages loaded, 0 targets configured)
    currently loading: java ... (3 packages)

0.27.2:

jingwen@jingwen-sea:~/code/intellij$ USE_BAZEL_VERSION=0.27.2 bazel build //aswb:aswb_bazel_zip --define=ij_product=android-studio-beta --nobuild
WARNING: Waiting for server process to terminate (waited 5 seconds, waiting at most 60)
Starting local Bazel server and connecting to it...
INFO: Analyzed target //aswb:aswb_bazel_zip (59 packages loaded, 2137 targets configured).
INFO: Found 1 target...
INFO: Deleting stale sandbox base /usr/local/google/home/jingwen/.cache/bazel/_bazel_jingwen/566de91536493bd30d1fb02c05327dbd/sandbox
INFO: Elapsed time: 10.472s
INFO: 0 processes.
INFO: Build completed successfully, 0 total actions

This affects all Bazel 0.28.0 users using any of the stable IntelliJ plugins.

cc @c-parsons

https://github.com/bazelbuild/bazel/commit/78e5fe2b6bcb2cd33c5d09221b47318a127ac2b0 is the breaking change for android_common. We should either rollback this change, or rollforward by whitelisting android_common. It's not feasible to ask all IntelliJ users to add --experimental_google_legacy_api.

I'll take on an action item to expand the IntelliJ CI coverage to ensure that this doesn't happen again: https://github.com/bazelbuild/intellij/pull/977

Update: please cherry pick https://github.com/bazelbuild/bazel/commit/a0af170f87c8230fcd8860599b983df097b646bd into 0.28.0.

@laurentlb 7d2bc7e caused a bug which was caught internally, 2260b970cb2a10c21a2fde116aa82c79be52991f is the fix, but it's not in 0.28.0. Please cheery-pick 2260b970cb2a10c21a2fde116aa82c79be52991f if you're releasing 0.28.1.

Related https://github.com/bazelbuild/bazel/issues/8707

@laurentlb Please cherry-pick c6ca6c2ccd9e11a87f837341ae05d2ba037975b1 to fix regression reported at https://github.com/bazelbuild/bazel/issues/3857#issuecomment-510538152

Created 0.28.1 with:
scripts/release/release.sh create 0.28.1 18cd9048526f067a4950c6ddbf4b1b3604760af0 2260b970cb2a10c21a2fde116aa82c79be52991f a0af170f87c8230fcd8860599b983df097b646bd c6ca6c2ccd9e11a87f837341ae05d2ba037975b1

You can download it from: https://releases.bazel.build/0.28.1/rc1/index.html

Users are starting to report issues with the IntelliJ plugin: https://github.com/bazelbuild/intellij/issues/976#issuecomment-512913723

Could we expedite promoting 0.28.1rc1 to a release?

The release notes are messed up:

This release contains contributions from many people at Google, as well as .

The sentence is incomplete. Did something go wrong with the release script?

The release notes link for 0.28.0 contains a link to the pull request for the release notes, rather than a link to the blog post.

Thanks, release descriptions on GitHub have been fixed.

Thank you

Was this page helpful?
0 / 5 - 0 ratings