Bazel: Remove dependency on jGit

Created on 11 Apr 2017  路  5Comments  路  Source: bazelbuild/bazel

P4 bug

Most helpful comment

May I ask why?

All 5 comments

May I ask why?

We've run into several bugs with it that do not inspire confidence, like throwing RuntimeExceptions that are not documented (see https://github.com/bazelbuild/bazel/blob/3fa1e883acd14a208e7c70c6e9b627981fd86dd9/src/main/java/com/google/devtools/build/lib/bazel/repository/GitCloner.java#L198-L200) and failing to set file permissions correctly on OS X in some cases (can't find the bug for that at the moment).

I'm not sure what we'd replace it with, though, and possibly we'd just deprecate these rule in favor of https://github.com/bazelbuild/bazel/blob/master/tools/build_defs/repo/git.bzl.

@kchodorow Have these bugs been reported to the JGit team?

The file permissions one: yes, I found it in the jGit bugtracker.

The runtime exceptions are a bigger issue which I think indicates a different philosophy of development.

This is fixed.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

ttsugriy picture ttsugriy  路  3Comments

f1recracker picture f1recracker  路  3Comments

GaofengCheng picture GaofengCheng  路  3Comments

meteorcloudy picture meteorcloudy  路  3Comments

davidzchen picture davidzchen  路  3Comments