Baseweb: [Styling] Longhand CSS attributes not used consistently for borders

[jasongi-actu]

Current Behavior

Non-longhand border styles are used in many components, instead of border[Left/Right/Top/Bottom][Style/Width/Color] border[Left/Right/Top/Bottom] or border[Style/Width/Color] is used instead. This can cause styling errors when overriding.

Expected Behavior

Longhand styles should be used at all times.

• [ x] I have searched the issues of this repository and believe that this is not a duplicate.

Here is a list of all the border[Top/Left/Right/Bottom] by searching the repo. There are also many cases of border[Style/Width/Color] that I haven't listed but also should probably be fixed.

Components:

• Accordion 1 2
  
• Header Navigation
• Tabs 1
• Table 1 2 3 4 5
• Input 1 2 3 4
• DataTable 1 2 3 4 5 6
• List 1 2 3

Tests:

• table-cell
• tree-view

Docs:

• table-of-contents
• code-box
• Gallery 1 2 3
• Tooltip 1 2 3 4
• Tokens

[gergelyke]

@jasongi-actu thank you for the thorough list! any chance you could help us send PRs fixing these?

[jasongi-actu]

I can if I can find time, however wondering what the best way to do this would be since technically it could be a (minor?) breaking change - as people who have encountered the warnings would probably have used the shorthand styles, so when they upgrade baseweb they may get warning for the shorthand styles and it will mess up their styling.

[gergelyke]

historically, we just went ahead and fixed these issues - what's your take on this @chasestarr @sandgraham @tajo @nadiia ?

[tajo]

We ask people to always use longhand properties so fixing this should not be considered as a breaking change.

Also for the tests and docs, it's ok to use shorthands. Those are our internal components, not a part of baseui.

[gergelyke]

@jasongi-actu in lights of Vojtech's comment, can you help us open a PR for this?

[hemildesai]

There's one example here as well - https://github.com/uber/baseweb/blob/master/src/card/styled-components.js#L47

[jasongi-actu]

@jasongi-actu in lights of Vojtech's comment, can you help us open a PR for this?

Have had a crack at this today
https://github.com/uber/baseweb/pull/3172