Badgeyay: use envparse or other utility like in open-event instead of harcoded variables.

Created on 16 Oct 2018  路  4Comments  路  Source: fossasia/badgeyay

I'm submitting a ...

  • [ ] bug report
  • [x] feature request

Current behaviour:

Currently before sending a PR, I have to switch back to ENV=PROD from LOCAL, making it hard for the development process. This can be cumbersome, if other variables are too set this way for my local setup, and needs to be reverted back to original for sending the PR.

Expected behaviour:

This can be avoided, if we use envparse to parse the environement variables. This way it will fetch the env variable that I have set locally on my PC, instead in the project. This is also a good practice as per one of the 12 principles of 12 factors app.

@yashLadha @gabru-md @ParthS007 your views on this?

_I would like to work on this._

All 4 comments

@rupav It is a great idea we can also set verification email domain using this.

@rupav Sound good to me. Please go ahead.

@rupav the issue is a certain solid one. You can proceed with it and create a PR
cheers!

@rupav Please update

Was this page helpful?
0 / 5 - 0 ratings

Related issues

mariobehling picture mariobehling  路  6Comments

niccokunzmann picture niccokunzmann  路  5Comments

niccokunzmann picture niccokunzmann  路  7Comments

0x48piraj picture 0x48piraj  路  8Comments

mariobehling picture mariobehling  路  7Comments